-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update simbody to a version with SimTK::CableSpan
support
#3911
Conversation
Ulterior motive is that the updated |
It looks like upstream simbody has done something with its libBLAS and now our CI is broken. It'll require some investigation. |
BLAS link failure is my fault from simbody/simbody#795 and simbody/simbody#796. I've got a fix ( 🤞 ) up at my fork halleysfifthinc/simbody#2 (commit: 4638ee275b29eb7a7f1507617746a2e67a921b73). You should be able to test it here by temporarily updating the GIT_URL and GIT_TAG to the commit of my fix. (Passing CI in my fork or upstream simbody doesn't mean anything, since the issue is at the downstream/link library resolution step.) |
Thanks for looking into it @halleysfifthinc Looking through Cmake-related PRs in simbody, it's gradually becoming clear that it needs a cmake make-over - at least w.r.t. handling libBLAS/libLAPACK. It's not going to be manageable, longer-term, to keep twiddling with little I'll have a look into centralizing the mess in |
Ok, I take it back - fixing simbody's CMake is going to be a multi-day deal, because it's accumulated quite a few global variables, special one-off flags, etc. :< |
I've been working on a series of PRs refactoring/modernizing the simbody CMake off and on since this spring. My most substantial rewrite will soon be ready to submit as a PR, but I'm mostly not touching the (But you are quite correct that the |
b0214e2
to
dc40e8c
Compare
dc40e8c
to
23957c4
Compare
Rebased as a single commit, it is now passing CI and is a minor enough change to merge straight away. Thanks again for speedily looking into it @halleysfifthinc ! |
Fixes issue N/A (@pepbos , @nickbianco )
Brief summary of changes
Testing I've completed
Looking for feedback on...
N/A
CHANGELOG.md (choose one)
This change is