Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update simbody to a version with SimTK::CableSpan support #3911

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Sep 19, 2024

Fixes issue N/A (@pepbos , @nickbianco )

Brief summary of changes

Testing I've completed

  • None

Looking for feedback on...

N/A

CHANGELOG.md (choose one)

  • no need to update because internal, until we start building prototypes on top of it etc. etc.

This change is Reviewable

@adamkewley
Copy link
Contributor Author

Ulterior motive is that the updated opensim-core main will be propagated to opensim-creator, which might make building prototypes, visualizers, etc. for SimTK::CableSpan easier, if required.

@adamkewley
Copy link
Contributor Author

It looks like upstream simbody has done something with its libBLAS and now our CI is broken. It'll require some investigation.

@halleysfifthinc
Copy link

BLAS link failure is my fault from simbody/simbody#795 and simbody/simbody#796. I've got a fix ( 🤞 ) up at my fork halleysfifthinc/simbody#2 (commit: 4638ee275b29eb7a7f1507617746a2e67a921b73). You should be able to test it here by temporarily updating the GIT_URL and GIT_TAG to the commit of my fix. (Passing CI in my fork or upstream simbody doesn't mean anything, since the issue is at the downstream/link library resolution step.)

@adamkewley
Copy link
Contributor Author

Thanks for looking into it @halleysfifthinc

Looking through Cmake-related PRs in simbody, it's gradually becoming clear that it needs a cmake make-over - at least w.r.t. handling libBLAS/libLAPACK. It's not going to be manageable, longer-term, to keep twiddling with little if..elses, rather than just using cmake as-intended (creating actual targets in one location).

I'll have a look into centralizing the mess in Platform/

@adamkewley
Copy link
Contributor Author

Ok, I take it back - fixing simbody's CMake is going to be a multi-day deal, because it's accumulated quite a few global variables, special one-off flags, etc. :<

@halleysfifthinc
Copy link

I've been working on a series of PRs refactoring/modernizing the simbody CMake off and on since this spring. My most substantial rewrite will soon be ready to submit as a PR, but I'm mostly not touching the Platform/ CMake settings.

(But you are quite correct that the Platform/ CMake config is a mess, and I think the best long-term solution would be to stop vendoring the precompiled BLAS/LAPACK binaries on Windows. Binaries in git is generally not a great idea, in addition to the unclear provenance of the libraries and likely violations of the library's license.)

@adamkewley adamkewley force-pushed the feature_update-simbody-with-cable-support branch from dc40e8c to 23957c4 Compare October 4, 2024 08:09
@adamkewley
Copy link
Contributor Author

Rebased as a single commit, it is now passing CI and is a minor enough change to merge straight away.

Thanks again for speedily looking into it @halleysfifthinc !

@adamkewley adamkewley merged commit c9336a8 into main Oct 4, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants