Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OCPBUGS-49303: rename 'master' to 'main' for ironic-image #60965

Merged
merged 2 commits into from
Jan 29, 2025
Merged

OCPBUGS-49303: rename 'master' to 'main' for ironic-image #60965

merged 2 commits into from
Jan 29, 2025

Conversation

DennisPeriquet
Copy link
Contributor

This PR is in support of renaming the default branch for https://github.com/openshift/ironic-image from 'master' to 'main'.

Unhold this PR only when:

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 24, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 24, 2025
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: This pull request references Jira Issue OCPBUGS-49303, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jadhaj

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/ironic-image from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 24, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@DennisPeriquet DennisPeriquet force-pushed the OCPBUGS-49303_ironic-image_master-1 branch from 196384f to eaec4b3 Compare January 27, 2025 16:11
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 27, 2025
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@DennisPeriquet: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-ironic-image-main-check-requirements openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-e2e-metal-ipi-bm openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-e2e-metal-ipi-ovn-ipv6 openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-e2e-metal-ipi-virtualmedia openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-images openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-okd-scos-e2e-aws-ovn openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-okd-scos-images openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-prevalidation-e2e-metal-ipi-bm-prevalidation openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-prevalidation-e2e-metal-ipi-ovn-ipv6-prevalidation openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-prevalidation-e2e-metal-ipi-virtualmedia-prevalidation openshift/ironic-image presubmit Presubmit changed
pull-ci-openshift-ironic-image-main-prevalidation-images openshift/ironic-image presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@dperique
Copy link
Contributor

/test rover-groups-config-validation

@elfosardo
Copy link
Contributor

/lgtm

@elfosardo
Copy link
Contributor

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DennisPeriquet, elfosardo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ironic-image-main-images

@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DennisPeriquet
Copy link
Contributor Author

/noop-pj-rehearse pull-ci-openshift-ironic-image-main-images

1 similar comment
@DennisPeriquet
Copy link
Contributor Author

/noop-pj-rehearse pull-ci-openshift-ironic-image-main-images

@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-ironic-image-main-images

@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@hector-vido
Copy link
Contributor

/pj-rehearse pull-ci-openshift-ironic-image-main-images

@openshift-ci-robot
Copy link
Contributor

@hector-vido: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@DennisPeriquet
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 29, 2025
@DennisPeriquet
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 53e6538 into openshift:master Jan 29, 2025
16 of 17 checks passed
@openshift-ci-robot
Copy link
Contributor

@DennisPeriquet: Jira Issue OCPBUGS-49303: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49303 has been moved to the MODIFIED state.

In response to this:

This PR is in support of renaming the default branch for https://github.com/openshift/ironic-image from 'master' to 'main'.

Unhold this PR only when:

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jadhaj jadhaj Awaiting requested review from jadhaj

@derekhiggins derekhiggins Awaiting requested review from derekhiggins

@dtantsur dtantsur Awaiting requested review from dtantsur

Assignees

@elfosardo elfosardo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DennisPeriquet @openshift-ci-robot @dperique @elfosardo @hector-vido @openshift-merge-robot