Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index ceph secrets to support multiple Ceph Pod instances #47641

Closed
wants to merge 1 commit into from
Closed

Index ceph secrets to support multiple Ceph Pod instances #47641

wants to merge 1 commit into from

Conversation

fmount
Copy link
Contributor

@fmount fmount commented Jan 15, 2024

As per [1] it is possible to deploy multiple ceph instances by passing a CEPH_CLUSTERS variable. It represents the number of Ceph Pods we'd like to deploy, and it allows to either test glance multistore, as well as it enables to simulate/test edge scenarios (DCN).
This patch just adds an index to the generated Ceph secret, so we do not fail in case there's only one Ceph cluster.

Depends-On: openstack-k8s-operators/install_yamls#654

[1] openstack-k8s-operators/install_yamls#654

@fmount
Index ceph secrets to support multiple Ceph Pod instances
0169173 
As per [1] it is possible to deploy multiple ceph instances by passing a
CEPH_CLUSTERS variable. It represents the number of Ceph Pods we'd like
to deploy, and it allows to either test glance multistore, as well as it
enables to simulate/test edge scenarios (DCN).
This patch just adds an index to the generated Ceph secret, so we do not
fail in case there's only one Ceph cluster.

[1] openstack-k8s-operators/install_yamls#654

Signed-off-by: Francesco Pantano <[email protected]>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@fmount: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openstack-k8s-operators-designate-operator-main-designate-operator-build-deploy-kuttl openstack-k8s-operators/designate-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-glance-operator-main-glance-operator-build-deploy openstack-k8s-operators/glance-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-glance-operator-main-glance-operator-build-deploy-kuttl openstack-k8s-operators/glance-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-glance-operator-main-glance-operator-build-deploy-tempest openstack-k8s-operators/glance-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ironic-operator-main-ironic-operator-build-deploy openstack-k8s-operators/ironic-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ironic-operator-main-ironic-operator-build-deploy-kuttl openstack-k8s-operators/ironic-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-ironic-operator-main-ironic-operator-build-deploy-tempest openstack-k8s-operators/ironic-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-cinder-operator-main-cinder-operator-build-deploy openstack-k8s-operators/cinder-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-cinder-operator-main-cinder-operator-build-deploy-kuttl openstack-k8s-operators/cinder-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-cinder-operator-main-cinder-operator-build-deploy-tempest openstack-k8s-operators/cinder-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-install_yamls-main-install-yamls-deploy openstack-k8s-operators/install_yamls presubmit Registry content changed
pull-ci-openstack-k8s-operators-swift-operator-main-swift-operator-build-deploy openstack-k8s-operators/swift-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-swift-operator-main-swift-operator-build-deploy-kuttl openstack-k8s-operators/swift-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-infra-operator-main-infra-operator-build-deploy openstack-k8s-operators/infra-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-infra-operator-main-infra-operator-build-deploy-kuttl openstack-k8s-operators/infra-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-manila-operator-main-manila-operator-build-deploy openstack-k8s-operators/manila-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-manila-operator-main-manila-operator-build-deploy-kuttl openstack-k8s-operators/manila-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-manila-operator-main-manila-operator-build-deploy-tempest openstack-k8s-operators/manila-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy-kuttl openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-neutron-operator-main-neutron-operator-build-deploy-tempest openstack-k8s-operators/neutron-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-openstack-baremetal-operator-main-openstack-baremetal-operator-build-deploy openstack-k8s-operators/openstack-baremetal-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy openstack-k8s-operators/dataplane-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-dataplane-operator-main-dataplane-operator-build-deploy-kuttl openstack-k8s-operators/dataplane-operator presubmit Registry content changed
pull-ci-openstack-k8s-operators-openstack-ansibleee-operator-main-openstack-ansibleee-operator-build-deploy openstack-k8s-operators/openstack-ansibleee-operator presubmit Registry content changed

A total of 46 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot requested review from arxcruz and rlandy January 15, 2024 09:44
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fmount
Once this PR has been reviewed and has the lgtm label, please assign dprince for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 15, 2024

@fmount: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fmount fmount mentioned this pull request Jan 15, 2024
Closed
@fmount fmount marked this pull request as draft January 16, 2024 11:43
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 16, 2024
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 15, 2024
@fmount fmount closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arxcruz arxcruz Awaiting requested review from arxcruz

@rlandy rlandy Awaiting requested review from rlandy

Assignees
No one assigned
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fmount @openshift-ci-robot @openshift-bot