[WIP] [DNM] Testing Fix conflicting network prefix for (C)UDNs. #2433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to internal conversion of network name to network prefix by GetSecondaryNetworkPrefix, which replaces '-' with '.', non-conflicting networks get conflicting internal names, e.g. for node switches. For example, NADs with network name 'tenant-blue' and 'tenant.blue' will have such conflict. In UDN case, network name was built as <namespace>.<name>, therefore 2 UDNs with namespace+name => network will have a conflict: 'test' + 'tenant-blue' => test.tenant-blue 'test-tenant' + 'blue' => test-tenant.blue If we use underscore instead of a period, it will allow us to work around this issue for (C)UDN. Move (C)UDN generate and parse network name function to utils to let other modules use this logic. Convert `GetNetworkVRFName` to use this function instead of prefix. Signed-off-by: Nadia Pinaeva <[email protected]>
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: trozet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@trozet: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to internal conversion of network name to network prefix by GetSecondaryNetworkPrefix, which replaces '-' with '.', non-conflicting networks get conflicting internal names, e.g. for node switches.
For example, NADs with network name 'tenant-blue' and 'tenant.blue' will have such conflict. In UDN case, network name was built as ., therefore 2 UDNs with namespace+name => network will have a conflict:
'test' + 'tenant-blue' => test.tenant-blue
'test-tenant' + 'blue' => test-tenant.blue
If we use underscore instead of a period, it will allow us to work around this issue for (C)UDN.
Move (C)UDN generate and parse network name function to utils to let other modules use this logic. Convert
GetNetworkVRFNameto use this function instead of prefix.📑 Description
Fixes #
Additional Information for reviewers
✅ Checks
How to verify it