Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

virt, udn: use l2bridge binding #29439

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Jan 14, 2025

This is the binding which we will use on 4.18.

In later releases we expect passt to replace it, but, its shortcomings (unable to preserve TCP connections during live migration) make it a bad candidate for the binding of the primary network attachment.

This is the binding which we will use on 4.18.

In later releases we expect passt to replace it, but, its shortcomings
(unable to preserve TCP connections during live migration) make it a bad
candidate for the binding of the primary network attachment.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 14, 2025

@qinqon should be just this, right ?

@openshift-ci openshift-ci bot requested review from danwinship and trozet January 14, 2025 15:47
@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 14, 2025

/test e2e-aws-ovn-virt-techpreview

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 06e55e2 link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/e2e-aws-ovn-serial 06e55e2 link true /test e2e-aws-ovn-serial
ci/prow/e2e-gcp-ovn 06e55e2 link true /test e2e-gcp-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 06e55e2 link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-cgroupsv2 06e55e2 link false /test e2e-aws-ovn-cgroupsv2
ci/prow/e2e-aws-ovn-upgrade 06e55e2 link false /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-edge-zones 06e55e2 link true /test e2e-aws-ovn-edge-zones
ci/prow/e2e-aws-ovn-single-node-serial 06e55e2 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node 06e55e2 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-csi 06e55e2 link false /test e2e-aws-csi
ci/prow/e2e-agnostic-ovn-cmd 06e55e2 link false /test e2e-agnostic-ovn-cmd
ci/prow/e2e-gcp-ovn-rt-upgrade 06e55e2 link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-gcp-ovn-upgrade 06e55e2 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp-csi 06e55e2 link false /test e2e-gcp-csi
ci/prow/e2e-aws-ovn-virt-techpreview 06e55e2 link false /test e2e-aws-ovn-virt-techpreview
ci/prow/e2e-openstack-ovn 06e55e2 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 06e55e2 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn 06e55e2 link false /test e2e-metal-ipi-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maiqueb
Copy link
Contributor Author

maiqueb commented Jan 15, 2025

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 15, 2025
@qinqon
Copy link
Contributor

qinqon commented Jan 20, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
Copy link
Contributor

openshift-ci bot commented Jan 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maiqueb, qinqon
Once this PR has been reviewed and has the lgtm label, please assign trozet for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants