Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.18] OCPBUGS-49437: Fix Portworx plugin's CSI translation to copy secret name & namespace #2187

Merged

Conversation

dobsonj
Copy link
Member

@dobsonj dobsonj commented Jan 28, 2025

https://issues.redhat.com/browse/OCPBUGS-49437

Clean git cherry-pick ae081128a3339ede070f281de76e1a75a0669fab + updated commit message.

/hold for #2185 to merge
/cc @openshift/storage @sdodson

@openshift-ci-robot openshift-ci-robot added the backports/validated-commits Indicates that all commits come to merged upstream PRs. label Jan 28, 2025
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 28, 2025
@openshift-ci openshift-ci bot requested a review from sdodson January 28, 2025 19:07
@openshift-ci-robot
Copy link

@dobsonj: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

Copy link

openshift-ci bot commented Jan 28, 2025

@dobsonj: GitHub didn't allow me to request PR reviews from the following users: openshift/storage.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

Clean git cherry-pick ae081128a3339ede070f281de76e1a75a0669fab + updated commit message.
/hold for #2185 to merge
/jira cherrypick OCPBUGS-48819
/cc @openshift/storage @sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jan 28, 2025
@dobsonj
Copy link
Member Author

dobsonj commented Jan 28, 2025

/jira cherrypick OCPBUGS-48819
?

@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-48819 has been cloned as Jira Issue OCPBUGS-49437. Will retitle bug to link to clone.
/retitle OCPBUGS-49437: [4.18] Fix Portworx plugin's CSI translation to copy secret name & namespace

In response to this:

/jira cherrypick OCPBUGS-48819
?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [4.18] Fix Portworx plugin's CSI translation to copy secret name & namespace OCPBUGS-49437: [4.18] Fix Portworx plugin's CSI translation to copy secret name & namespace Jan 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2025
@openshift-ci-robot
Copy link

@dobsonj: This pull request references Jira Issue OCPBUGS-49437, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-48819 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Clean git cherry-pick ae081128a3339ede070f281de76e1a75a0669fab + updated commit message.
/hold for #2185 to merge
/jira cherrypick OCPBUGS-48819
/cc @openshift/storage @sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 28, 2025
@dobsonj dobsonj changed the title OCPBUGS-49437: [4.18] Fix Portworx plugin's CSI translation to copy secret name & namespace [4.18] OCPBUGS-49437: Fix Portworx plugin's CSI translation to copy secret name & namespace Jan 28, 2025
@sdodson
Copy link
Member

sdodson commented Jan 29, 2025

/retest-required
Failed in build step

error: error creating buildah builder: initializing source docker://image-registry.openshift-image-registry.svc:5000/ci-op-zwf9xv3s/pipeline@sha256:cb7878b60ef1e0bcb7274fde530f149e319f3a89f0ce1906f5c2212d496fac07: unable to retrieve auth token: invalid username/password: authentication required

@bertinatto
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, dobsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

@dobsonj: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-aws-ovn-serial d14a81f link false /test k8s-e2e-aws-ovn-serial

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sdodson
Copy link
Member

sdodson commented Jan 29, 2025

/retest-required

@sdodson
Copy link
Member

sdodson commented Jan 29, 2025

/jira refresh

@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-49437, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sdodson
Copy link
Member

sdodson commented Jan 29, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 29, 2025
@openshift-ci-robot
Copy link

@sdodson: This pull request references Jira Issue OCPBUGS-49437, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48819 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48819 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jan 29, 2025
@sdodson sdodson added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Jan 29, 2025
@sdodson
Copy link
Member

sdodson commented Jan 29, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e411fa8 into openshift:release-4.18 Jan 29, 2025
20 of 21 checks passed
@openshift-ci-robot
Copy link

@dobsonj: Jira Issue OCPBUGS-49437: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-49437 has been moved to the MODIFIED state.

In response to this:

https://issues.redhat.com/browse/OCPBUGS-49437

Clean git cherry-pick ae081128a3339ede070f281de76e1a75a0669fab + updated commit message.

/hold for #2185 to merge
/cc @openshift/storage @sdodson

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202501300201.p0.ge411fa8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.18.0-202501300201.p0.ge411fa8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202501300201.p0.ge411fa8.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202501300201.p0.ge411fa8.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.