Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS-3835: Add gcp endpoints to the installer config #9363

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

barbacbd
Copy link
Contributor

** Added the endpoints including the name and url to the install config.
** Added Specific endpoint names that able to be used/customized.
** Added validation for the GCP Service Endpoints.

** Added the endpoints including the name and url to the install config.
** Validate the user entered data.
** Added validation for the GCP Service Endpoints.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 14, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 14, 2025

@barbacbd: This pull request references CORS-3835 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

** Added the endpoints including the name and url to the install config.
** Added Specific endpoint names that able to be used/customized.
** Added validation for the GCP Service Endpoints.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jan 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from barbacbd. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barbacbd
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jan 16, 2025

@barbacbd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 62fa0a5 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-secureboot 62fa0a5 link false /test e2e-gcp-secureboot
ci/prow/e2e-gcp-default-config 62fa0a5 link false /test e2e-gcp-default-config
ci/prow/e2e-gcp-ovn-byo-vpc 62fa0a5 link false /test e2e-gcp-ovn-byo-vpc
ci/prow/e2e-azure-ovn-resourcegroup 62fa0a5 link false /test e2e-azure-ovn-resourcegroup
ci/prow/e2e-vsphere-static-ovn 62fa0a5 link false /test e2e-vsphere-static-ovn
ci/prow/e2e-vsphere-ovn-multi-network 62fa0a5 link false /test e2e-vsphere-ovn-multi-network
ci/prow/e2e-gcp-ovn-xpn 62fa0a5 link false /test e2e-gcp-ovn-xpn
ci/prow/golint 62fa0a5 link true /test golint
ci/prow/e2e-gcp-ovn 62fa0a5 link true /test e2e-gcp-ovn
ci/prow/verify-codegen 62fa0a5 link true /test verify-codegen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants