OCPBUGS-48256: Run iscsiadm for agent-based iSCSI installations #9356
Conversation
openshift-ci-robot
added
jira/severity-important
|
@bfournie: This pull request references Jira Issue OCPBUGS-48256, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@bfournie: This pull request references Jira Issue OCPBUGS-48256, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cc @pawanpinjarkar |
|
/cc @adriengentil |
| @@ -382,6 +382,7 @@ func getDefaultEnabledServices() []string { | |||
| "oci-eval-user-data.service", | |||
| "iscsistart.service", | |||
| "set-hostname.service", | |||
| "iscsiadm.service", | |||
There was a problem hiding this comment.
is there a benefit to run iscsiadm instead of enabling iscsid (and perhaps configure iscsistart after iscsid has started) directly?
There was a problem hiding this comment.
According to [RHEL 9 doumentation] it seems iscsiadm should be used to start iscsid (https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/managing_storage_devices/configuring-an-iscsi-initiator_managing-storage-devices#configuring-an-iscsi-initiator_managing-storage-devices)
By default, an iSCSI service is lazily started and the service starts after running the iscsiadm command. If root is not on an iSCSI device or there are no nodes marked with node.startup = automatic then the iSCSI service will not start until an iscsiadm command is executed that requires iscsid or the iscsi kernel modules to be started.
I've also confirmed it works by using ExecStart=systemctl start iscsid.service instead of iscsiadm in the service however.
bfournie
force-pushed
the
iscsi-installation
branch
from
faddfbb to
c7972a6
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
The agent-based installer currently runs iscsistart to ensure it can boot off of an iSCSI target. However, in order to access the final rhcos image written to the the target by coreos-installer, iscsiadm must be run which will start iscsid. See https://docs.redhat.com/en/documentation/red_hat_enterprise_linux/9/html/managing_storage_devices/configuring-an-iscsi-initiator_managing-storage-devices#configuring-an-iscsi-initiator_managing-storage-devices for more info.
bfournie
force-pushed
the
iscsi-installation
branch
from
c7972a6 to
4cebd5d
Compare
|
/lgtm |
|
@bfournie: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label acknowledge-critical-fixes-only |
openshift-ci
bot
added
the
acknowledge-critical-fixes-only
openshift-merge-bot
bot
merged commit 5981419
into
openshift:main
|
@bfournie: Jira Issue OCPBUGS-48256: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-48256 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-altinfra |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-terraform-providers |
|
[ART PR BUILD NOTIFIER] Distgit: ose-installer-artifacts |
|
[ART PR BUILD NOTIFIER] Distgit: ose-baremetal-installer |
|
/cherry-pick release-4.18 |
|
@bfournie: new pull request created: #9379 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The agent-based installer currently runs iscsistart to ensure it can boot off of an iSCSI target. However, in order to access the final rhcos image written to the the target by coreos-installer, iscsiadm must be run which will start iscsid. See
iSCSI initiator reference for more info.