Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump controller-runtime and client-go deps #2362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bump controller-runtime and client-go deps #2362

wants to merge 1 commit into from

Conversation

celebdor
Copy link
Contributor

It also cleaned up a lot of related dependencies that were long outdated.

@celebdor
Bump controller-runtime and client-go deps
bc5dc5e 
It also cleaned up a lot of related dependencies that were long
outdated.

Signed-off-by: Antoni Segura Puimedon <[email protected]>
@openshift-ci openshift-ci bot requested review from dlom and suhanime July 19, 2024 09:13
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: celebdor
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 19, 2024

@celebdor: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/coverage bc5dc5e link true /test coverage
ci/prow/e2e-pool bc5dc5e link true /test e2e-pool
ci/prow/images bc5dc5e link true /test images
ci/prow/unit bc5dc5e link true /test unit
ci/prow/security bc5dc5e link true /test security
ci/prow/periodic-images bc5dc5e link true /test periodic-images
ci/prow/verify bc5dc5e link true /test verify
ci/prow/e2e bc5dc5e link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlom dlom Awaiting requested review from dlom

@suhanime suhanime Awaiting requested review from suhanime

Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@celebdor @openshift-merge-robot @openshift-bot