-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mce-2.6] Fix AWS STS for RHEL8/9 transition #2324
base: mce-2.6
Are you sure you want to change the base?
[mce-2.6] Fix AWS STS for RHEL8/9 transition #2324
Conversation
In openshift#2260 we changed how we're invoking the openshift-install binary. Before: Copy openshift-install into the hive container and run it via `/usr/bin/hiveutil install-manager` After: Copy hiveutil into the installer container and run installer via `/output/hiveutil.rhel$VER install-manager` What we missed was that, for STS flows, we inject an AWS credentials file containing a `credential_process` that invoked `/usr/bin/hiveutil install-manager aws-credentials` -- but `hiveutil` no longer lives there. Fix. HIVE-2400
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## mce-2.6 #2324 +/- ##
========================================
Coverage 58.55% 58.55%
========================================
Files 182 182
Lines 25829 25829
========================================
Hits 15124 15124
Misses 9429 9429
Partials 1276 1276
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This is an automated cherry-pick of #2322
/assign 2uasimojo