Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mce-2.6] Fix AWS STS for RHEL8/9 transition #2324

Open
wants to merge 1 commit into
base: mce-2.6
Choose a base branch
from
Open

[mce-2.6] Fix AWS STS for RHEL8/9 transition #2324

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2322

/assign 2uasimojo

@2uasimojo
Fix AWS STS for RHEL8/9 transition
d597217 
In openshift#2260 we changed how we're invoking the openshift-install binary.

Before: Copy openshift-install into the hive container and run it via
`/usr/bin/hiveutil install-manager`

After: Copy hiveutil into the installer container and run installer via
`/output/hiveutil.rhel$VER install-manager`

What we missed was that, for STS flows, we inject an AWS credentials
file containing a `credential_process` that invoked `/usr/bin/hiveutil
install-manager aws-credentials` -- but `hiveutil` no longer lives
there.

Fix.

HIVE-2400
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 21, 2024
Merged
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please ask for approval from 2uasimojo. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 58.55%. Comparing base (0ed7370) to head (d597217).
Report is 30 commits behind head on mce-2.6.

Files with missing lines Patch % Lines
pkg/install/generate.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           mce-2.6    #2324   +/-   ##
========================================
  Coverage    58.55%   58.55%           
========================================
  Files          182      182           
  Lines        25829    25829           
========================================
  Hits         15124    15124           
  Misses        9429     9429           
  Partials      1276     1276
Files with missing lines Coverage Δ
pkg/install/generate.go 47.62% <50.00%> (ø)

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 22, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-pool d597217 link true /test e2e-pool
ci/prow/security d597217 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 20, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@2uasimojo
Copy link
Member

@celebdor @lleshchi This is obsolete now, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2uasimojo 2uasimojo Awaiting requested review from 2uasimojo

@lleshchi lleshchi Awaiting requested review from lleshchi

Assignees

@2uasimojo 2uasimojo

Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@openshift-cherrypick-robot @openshift-bot @openshift-merge-robot @2uasimojo