OCPBUGS-43664: Add vendor and architecture specific tuning options #1191

MarSik · 2024-10-22T09:18:52Z

CNF-14090: Add vendor and architecture specific tuning options

Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change
When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning
This makes use of a new helper function added to tuned to detect the system name and architecture
Update unit tests to account for the various changes
Add new unit tests to cover the platform specific tuning

CNF-14090: Re-sync e2e test yaml for tuning changes
CNF-14090: Use variable composition for idle_poll

idle=poll is only supported on x86
Update tests to account for changes
Add explaination comments to empty values in openshift-node-performance

CNF-14090: Re-sync e2e test yaml for tuning changes
CNF-14090: Fix active/passive pstates
CNF-14090: Re-sync e2e test yaml for tuning changes

…hift#1083) * CNF-14090: Add vendor and architecture specific tuning options - Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change - When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning - This makes use of a new helper function added to tuned to detect the system name and architecture - Update unit tests to account for the various changes - Add new unit tests to cover the platform specific tuning * CNF-14090: Re-sync e2e test yaml for tuning changes * CNF-14090: Use variable composition for idle_poll - idle=poll is only supported on x86 - Update tests to account for changes - Add explaination comments to empty values in openshift-node-performance * CNF-14090: Re-sync e2e test yaml for tuning changes * CNF-14090: Fix active/passive pstates * CNF-14090: Re-sync e2e test yaml for tuning changes

openshift-ci-robot · 2024-10-22T09:18:56Z

@MarSik: This pull request references CNF-14090 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

CNF-14090: Add vendor and architecture specific tuning options

Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change

When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning

This makes use of a new helper function added to tuned to detect the system name and architecture

Update unit tests to account for the various changes

Add new unit tests to cover the platform specific tuning

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Use variable composition for idle_poll

idle=poll is only supported on x86

Update tests to account for changes

Add explaination comments to empty values in openshift-node-performance

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Fix active/passive pstates

CNF-14090: Re-sync e2e test yaml for tuning changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-10-22T09:19:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MarSik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [MarSik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MarSik · 2024-10-22T09:21:03Z

/jira cherry-pick CNF-14090

openshift-ci-robot · 2024-10-22T09:21:06Z

@MarSik: Ignoring requests to cherry-pick non-bug issues: CNF-14090

In response to this:

/jira cherry-pick CNF-14090

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik · 2024-10-22T09:24:59Z

/jira cherry-pick OCPBUGS-43660

openshift-ci-robot · 2024-10-22T09:26:11Z

@MarSik: Jira Issue OCPBUGS-43660 has been cloned as Jira Issue OCPBUGS-43664. Will retitle bug to link to clone.
/retitle OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083)

In response to this:

/jira cherry-pick OCPBUGS-43660

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-22T09:26:19Z

@MarSik: This pull request references Jira Issue OCPBUGS-43664, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-43665 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
expected dependent Jira Issue OCPBUGS-43660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CNF-14090: Add vendor and architecture specific tuning options

Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change

When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning

This makes use of a new helper function added to tuned to detect the system name and architecture

Update unit tests to account for the various changes

Add new unit tests to cover the platform specific tuning

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Use variable composition for idle_poll

idle=poll is only supported on x86

Update tests to account for changes

Add explaination comments to empty values in openshift-node-performance

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Fix active/passive pstates

CNF-14090: Re-sync e2e test yaml for tuning changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik · 2024-10-22T09:27:09Z

/jira cherry-pick OCPBUGS-43665

openshift-ci-robot · 2024-10-22T09:28:18Z

@MarSik: Jira Issue OCPBUGS-43665 has been cloned as Jira Issue OCPBUGS-43666. Will retitle bug to link to clone.
/retitle OCPBUGS-43666: OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083)

In response to this:

/jira cherry-pick OCPBUGS-43665

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-22T09:28:33Z

@MarSik: This pull request references Jira Issue OCPBUGS-43666, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-43665 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
expected dependent Jira Issue OCPBUGS-43665 to target a version in 4.18.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CNF-14090: Add vendor and architecture specific tuning options

Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change

When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning

This makes use of a new helper function added to tuned to detect the system name and architecture

Update unit tests to account for the various changes

Add new unit tests to cover the platform specific tuning

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Use variable composition for idle_poll

idle=poll is only supported on x86

Update tests to account for changes

Add explaination comments to empty values in openshift-node-performance

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Fix active/passive pstates

CNF-14090: Re-sync e2e test yaml for tuning changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik · 2024-10-22T09:29:57Z

/jira refresh

openshift-ci-robot · 2024-10-22T09:30:00Z

@MarSik: This pull request references Jira Issue OCPBUGS-43666, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected dependent Jira Issue OCPBUGS-43665 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is New instead
expected dependent Jira Issue OCPBUGS-43665 to target a version in 4.18.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-10-22T09:33:39Z

@MarSik: This pull request references Jira Issue OCPBUGS-43664, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead
expected dependent Jira Issue OCPBUGS-43660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
expected dependent Jira Issue OCPBUGS-43665 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Obsolete) instead
expected dependent Jira Issue OCPBUGS-43665 to target a version in 4.18.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

CNF-14090: Add vendor and architecture specific tuning options

Performance tuning support for 3 platforms (amd/x86,arm/aarch64,intel/x86) is added in this change

When a valid platform is detected the additional platform specific tuning will be imported alongside the default tuning

This makes use of a new helper function added to tuned to detect the system name and architecture

Update unit tests to account for the various changes

Add new unit tests to cover the platform specific tuning

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Use variable composition for idle_poll

idle=poll is only supported on x86

Update tests to account for changes

Add explaination comments to empty values in openshift-node-performance

CNF-14090: Re-sync e2e test yaml for tuning changes

CNF-14090: Fix active/passive pstates

CNF-14090: Re-sync e2e test yaml for tuning changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik · 2024-10-22T09:33:58Z

/jira refresh

openshift-ci-robot · 2024-10-22T09:34:02Z

@MarSik: This pull request references Jira Issue OCPBUGS-43664, which is invalid:

expected the bug to be open, but it isn't
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is Closed (Obsolete) instead
expected dependent Jira Issue OCPBUGS-43660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
expected dependent Jira Issue OCPBUGS-43665 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Obsolete) instead
expected dependent Jira Issue OCPBUGS-43665 to target a version in 4.18.0, but it targets "4.17.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

MarSik · 2024-10-22T09:35:24Z

/jira refresh

openshift-ci-robot · 2024-10-22T09:35:28Z

@MarSik: This pull request references Jira Issue OCPBUGS-43664, which is invalid:

expected dependent Jira Issue OCPBUGS-43660 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jmencak · 2024-10-22T09:39:35Z

...testdata/render-expected-output/bootstrap/extra-ctrcfg/openshift-bootstrap-master_tuned.yaml

+
+
+      cmdline_realtime_intel=tsc=reliable nmi_watchdog=0 mce=off
+


Nit: why so many empty lines? Similarly elsewhere. Was this in the original PR too?

The templating generates it like this.

And there is no way to fix it? It is pretty ugly.

It is the same for the old profiles and this is the generated content. Yes, there is a way to fix it by using {{- xxx -}} properly in all the templates. But not in this PR as it is a wider issue.

bartwensley · 2024-10-22T11:44:42Z

@MarSik - are you sure you want to cherry-pick this now? I think it would make sense to wait for at least some degree of QE to happen for this on OCP 4.18 before the cherry-pick - given that it changes kernel parameters and such, there is potential for significant breakage if something is wrong.

MarSik · 2024-10-22T11:56:13Z

@bartwensley QE approval of 4.18 is needed to merge this indeed. But I want to be ready.

MarSik · 2024-10-22T11:59:01Z

@bartwensley Btw, the idea is that this does not change any kernel arguments for Intel. Just for the other new platforms. And it is easier to verify with the PR posted (clusterbot can build a PR, yesterday it gave me an AMD VM though..)

fontivan · 2024-10-22T14:34:33Z

/retest

fontivan · 2024-10-22T16:41:41Z

4.17 still needs backports to fix CI failures, will need to be rebased once both of these PRs are merged

openshift-ci · 2024-10-22T17:17:04Z

@MarSik: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-pao	`7879a8f`	link	true	`/test e2e-hypershift-pao`
ci/prow/e2e-gcp-pao	`7879a8f`	link	true	`/test e2e-gcp-pao`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 22, 2024

openshift-ci bot requested review from jmencak and Tal-or October 22, 2024 09:19

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024

openshift-ci bot changed the title ~~CNF-14090: Add vendor and architecture specific tuning options (#1083)~~ OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083) Oct 22, 2024

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 22, 2024

openshift-ci bot changed the title ~~OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083)~~ OCPBUGS-43666: OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083) Oct 22, 2024

MarSik changed the title ~~OCPBUGS-43666: OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083)~~ OCPBUGS-43666: CNF-14090: Add vendor and architecture specific tuning options (#1083) Oct 22, 2024

MarSik changed the title ~~OCPBUGS-43666: CNF-14090: Add vendor and architecture specific tuning options (#1083)~~ OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083) Oct 22, 2024

MarSik changed the title ~~OCPBUGS-43664: CNF-14090: Add vendor and architecture specific tuning options (#1083)~~ OCPBUGS-43664: Add vendor and architecture specific tuning options Oct 22, 2024

jmencak reviewed Oct 22, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-43664: Add vendor and architecture specific tuning options #1191

OCPBUGS-43664: Add vendor and architecture specific tuning options #1191

MarSik commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci bot commented Oct 22, 2024

MarSik commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

jmencak Oct 22, 2024

MarSik Oct 22, 2024

MarSik Oct 22, 2024

bartwensley Oct 22, 2024

MarSik Oct 22, 2024

bartwensley commented Oct 22, 2024

MarSik commented Oct 22, 2024

MarSik commented Oct 22, 2024

fontivan commented Oct 22, 2024

fontivan commented Oct 22, 2024

openshift-ci bot commented Oct 22, 2024

OCPBUGS-43664: Add vendor and architecture specific tuning options #1191

Are you sure you want to change the base?

OCPBUGS-43664: Add vendor and architecture specific tuning options #1191

Conversation

MarSik commented Oct 22, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Oct 22, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Oct 22, 2024

MarSik commented Oct 22, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Oct 22, 2024 • edited by openshift-ci bot Loading

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024 • edited by openshift-ci bot Loading

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

MarSik commented Oct 22, 2024

openshift-ci-robot commented Oct 22, 2024

jmencak Oct 22, 2024

Choose a reason for hiding this comment

MarSik Oct 22, 2024

Choose a reason for hiding this comment

MarSik Oct 22, 2024

Choose a reason for hiding this comment

bartwensley Oct 22, 2024

Choose a reason for hiding this comment

MarSik Oct 22, 2024

Choose a reason for hiding this comment

bartwensley commented Oct 22, 2024

MarSik commented Oct 22, 2024

MarSik commented Oct 22, 2024

fontivan commented Oct 22, 2024

fontivan commented Oct 22, 2024

openshift-ci bot commented Oct 22, 2024

MarSik commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

MarSik commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 22, 2024 •

edited by openshift-ci bot

Loading