WIP: amend irqbalance tests to check IRQBALANCE_BANNED_CPUS #1165
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yanirq The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/cc jmencak |
|
If we do this change, will this not break the potential |
it will, currently setting this as WIP. I might add a more modular option to check for both values if required |
| @@ -359,7 +359,7 @@ func findIrqBalanceBannedCPUsVarFromConf(conf string) string { | |||
| if strings.HasPrefix(line, "#") { | |||
| continue | |||
| } | |||
| if !strings.HasPrefix(line, "IRQBALANCE_BANNED_CPUS") { | |||
| if !strings.HasPrefix(line, "IRQBALANCE_BANNED_CPULIST") { | |||
There was a problem hiding this comment.
Is this change alone sufficient, because the CPULIST now contains the list where as the IRQBALANCE_BANNED_CPUS was mask ?,
Use IRQBALANCE_BANNED_CPULIST instead of the deprecated IRQBALANCE_BANNED_CPUS in irqbalance tests to match tuned irqbalance plugin xref: redhat-performance/tuned@7825b11
yanirq
force-pushed
the
banned_cpus_4_18
branch
from
ba91e24
to
eae70fc
Compare
|
@yanirq: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Use IRQBALANCE_BANNED_CPULIST instead of the deprecated IRQBALANCE_BANNED_CPUS in irqbalance tests to match tuned irqbalance plugin
xref: redhat-performance/tuned@7825b11