Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installing loki < 6.0 with the stable channel on OCP < 4.14 #654

Open
wants to merge 1 commit into
base: netobserv-perf-tests
Choose a base branch
from

Conversation

AdityaHonkalas
Copy link

Added the changes to install Loki operator based on the OCP version.

@openshift-ci openshift-ci bot requested review from jotak and memodi October 9, 2024 10:20
Copy link

openshift-ci bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AdityaHonkalas
Once this PR has been reviewed and has the lgtm label, please assign mffiedler for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Oct 9, 2024

Hi @AdityaHonkalas. Thanks for your PR.

I'm waiting for a openshift-qe member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

@memodi memodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @AdityaHonkalas for the PR.

scripts/netobserv.sh Outdated Show resolved Hide resolved
scripts/loki/loki-released-subscription.yaml Outdated Show resolved Hide resolved
scripts/loki/loki-released-subscription.yaml Outdated Show resolved Hide resolved
scripts/netobserv.sh Outdated Show resolved Hide resolved
scripts/netobserv.sh Outdated Show resolved Hide resolved
@AdityaHonkalas AdityaHonkalas changed the title Changes for installing loki < 6.0 with the stable channel on OCP < 4.17 Installing loki < 6.0 with the stable channel on OCP < 4.14 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants