Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a prepare-release target… #4

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Add a prepare-release target… #4

merged 1 commit into from
Oct 24, 2023

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Oct 24, 2023 •
edited
Loading

… and update the version to 0.1.0 to prepare the release to come.

$ make prepare-release
mkdir -p /tmp/task-git-0.1.0/task/task-git || true
helm template  . > /tmp/task-git-0.1.0/task/task-git/task-git.yaml
cp README.md /tmp/task-git-0.1.0/task/task-git/
go run github.com/openshift-pipelines/tektoncd-catalog/cmd/catalog-cd@main release --output release --version 0.1.0 /tmp/task-git-0.1.0/task/task-git
# Found 1 path to inspect!
# Scan Tekton resources on: /tmp/task-git-0.1.0/task/task-git
# Loading resource file: "/tmp/task-git-0.1.0/task/task-git/task-git.yaml"
# Saving release contract at "release/catalog.yaml"
# Creating tarball at "release/resources.tar.gz"
Now you can release:
  git tag v0.1.0
  gh release create v0.1.0 --generate-notes
  gh release upload v0.1.0 release/catalog.yaml
  gh release upload v0.1.0 release/resources.tar.gz

Signed-off-by: Vincent Demeester [email protected]

@vdemeester
Add a prepare-release target…
3f59bf2 
… and update the version to 0.1.0 to prepare the release to come.

Signed-off-by: Vincent Demeester <[email protected]>
otaviof
otaviof reviewed Oct 24, 2023
View reviewed changes
Makefile
@@ -1,6 +1,9 @@
# using the chart name and version from chart's metadata
CHART_NAME ?= $(shell awk '/^name:/ { print $$2 }' Chart.yaml)
CHART_VESION ?= $(shell awk '/^version:/ { print $$2 }' Chart.yaml)
CHART_VERSION ?= $(shell awk '/^version:/ { print $$2 }' Chart.yaml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch! Thank you 🙏

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😛 I spend a few mintues figuring out why it would create task-git- as a folder 😛

otaviof
otaviof approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@otaviof otaviof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks! Let's iterate on this.

@otaviof otaviof merged commit 37741db into main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@otaviof otaviof otaviof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vdemeester @otaviof