[WIP] SRVKP-6191 new basic test for http resolver #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayesh-garg
force-pushed
the
SRVKP-6191
branch
3 times, most recently
from
a53e467
to
b0c711e
Compare
ppitonak
requested changes
Sep 10, 2024
jayesh-garg
force-pushed
the
SRVKP-6191
branch
from
b0c711e
to
201e368
Compare
ppitonak
requested changes
Sep 11, 2024
testdata/resolvers/pipelineruns/http-resolver-pipelinerun-private.yaml
Outdated
Show resolved
Hide resolved
jayesh-garg
changed the title
jayesh-garg
force-pushed
the
SRVKP-6191
branch
from
201e368
to
dc12f60
Compare
jayesh-garg
changed the title
ppitonak
requested changes
Sep 24, 2024
| @@ -0,0 +1,19 @@ | |||
| apiVersion: tekton.dev/v1 | |||
There was a problem hiding this comment.
What is this good for? You are not using HTTP resolver anywhere 🤔
jayesh-garg
force-pushed
the
SRVKP-6191
branch
2 times, most recently
from
3f6b6a0
to
ebd0696
Compare
jayesh-garg
changed the title
jayesh-garg
force-pushed
the
SRVKP-6191
branch
from
ebd0696
to
ef266c3
Compare
ppitonak
requested changes
Oct 23, 2024
| * Create | ||
| |S.NO|resource_dir | | ||
| |----|-----------------------------------------------------------------| | ||
| |1 |testdata/resolvers/pipelineruns/http-resolver-pipelinerun.yaml | |
There was a problem hiding this comment.
Did you test it? This will fail because pipeline doesn't exist
| taskRef: | ||
| resolver: http | ||
| params: | ||
| url: https://github.com/tektoncd/catalog |
| @@ -0,0 +1,19 @@ | |||
| apiVersion: tekton.dev/v1 | |||
| - name: url | ||
| value: "https://github.com/tektoncd/catalog" | ||
| - name: method | ||
| value: "GET" |
There was a problem hiding this comment.
Pipeline doesn't have any params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.