-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] SRVKP-6191 new basic test for http resolver #370
base: master
Are you sure you want to change the base?
Conversation
a53e467
to
b0c711e
Compare
b0c711e
to
201e368
Compare
testdata/resolvers/pipelineruns/http-resolver-pipelinerun-private.yaml
Outdated
Show resolved
Hide resolved
201e368
to
dc12f60
Compare
@@ -0,0 +1,19 @@ | |||
apiVersion: tekton.dev/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is this good for? You are not using HTTP resolver anywhere 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this task is not used at all
3f6b6a0
to
ebd0696
Compare
ebd0696
to
ef266c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to rebase because there is a conflict in tc_spec_map.json
* Create | ||
|S.NO|resource_dir | | ||
|----|-----------------------------------------------------------------| | ||
|1 |testdata/resolvers/pipelineruns/http-resolver-pipelinerun.yaml | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test it? This will fail because pipeline doesn't exist
taskRef: | ||
resolver: http | ||
params: | ||
url: https://github.com/tektoncd/catalog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will not work
@@ -0,0 +1,19 @@ | |||
apiVersion: tekton.dev/v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this task is not used at all
- name: url | ||
value: "https://github.com/tektoncd/catalog" | ||
- name: method | ||
value: "GET" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pipeline doesn't have any params
No description provided.