Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version #2073

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version #2073

wants to merge 1 commit into from
+35 −11

Conversation

fontivan
Copy link
Contributor

  • Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
  • The gimme tool seems to be abandoned and does not work correctly for modern go versions (gimme stable does not work for latest Go (v1.21.0) travis-ci/gimme#210)
  • Designate the top level go.mod as the source of truth for the go version in the project
  • Includes notes on where this version needs to be updated to match
  • Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos

@openshift-ci-robot
Copy link
Collaborator

@fontivan: This pull request references CNF-14990 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

In response to this:

  • Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
  • The gimme tool seems to be abandoned and does not work correctly for modern go versions (gimme stable does not work for latest Go (v1.21.0) travis-ci/gimme#210)
  • Designate the top level go.mod as the source of truth for the go version in the project
  • Includes notes on where this version needs to be updated to match
  • Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fontivan
Once this PR has been reviewed and has the lgtm label, please assign zeeke for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fontivan
infra: CNF-14990: Replace abandoned gimme tool & Provide alignment fo…
6d8e2cf 
…r golang version

- Since golang 1.21, go is much better at managing its own version requirements (https://go.dev/doc/toolchain)
- The gimme tool seems to be abandoned and does not work correctly for modern go versions (travis-ci/gimme#210)
- Designate the top level go.mod as the source of truth for the go version in the project
- Includes notes on where this version needs to be updated to match
- Update fedora image used in ci job to fedora 40 since it provides golang 1.22 in its repos
@fontivan fontivan changed the title CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version infra: CNF-14990: Replace abandoned gimme tool & Provide alignment for golang version Oct 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 17, 2024

@fontivan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images 6d8e2cf link true /test images
ci/prow/e2e-aws-ran-profile 6d8e2cf link false /test e2e-aws-ran-profile
ci/prow/e2e-aws-ci-tests 6d8e2cf link true /test e2e-aws-ci-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@fontivan
Copy link
Contributor Author

The three failing CI tests ares failing since the CI does not use build root from the pr but instead from HEAD of the target branch. More details are available in https://issues.redhat.com/browse/CNF-15003

@fontivan
Copy link
Contributor Author

/cc @imiller0 @ffromani @lack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ijolliffe ijolliffe Awaiting requested review from ijolliffe

@Missxiaoguo Missxiaoguo Awaiting requested review from Missxiaoguo

@ffromani ffromani Awaiting requested review from ffromani

@imiller0 imiller0 Awaiting requested review from imiller0

@lack lack Awaiting requested review from lack

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fontivan @openshift-ci-robot