Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding func-deploy-pac patch script #749

Conversation

jrangelramos
Copy link

@jrangelramos jrangelramos commented Mar 6, 2024

Changes

  • 🎁 Adding support to use scripts to patch midstream files
  • 🎁 Adding the func-deploy-pac.yaml as as script patch, so it will always be included in release-next and future release branches (i.e. serverless-1.33).

This prevents manual add in future such as this one #748

@jrangelramos jrangelramos requested a review from matejvasek March 6, 2024 17:14
@openshift-ci openshift-ci bot requested review from dsimansk and jcrossley3 March 6, 2024 17:14
@jrangelramos jrangelramos marked this pull request as draft March 6, 2024 19:31
@jrangelramos jrangelramos marked this pull request as ready for review March 7, 2024 16:57
@jrangelramos jrangelramos force-pushed the add-func-deploy-pac-override branch from fbb0b3c to 72db8d8 Compare March 7, 2024 17:02
@jrangelramos jrangelramos changed the title adding func-deploy-pac override patch adding func-deploy-pac patch script Mar 7, 2024
@jrangelramos jrangelramos force-pushed the add-func-deploy-pac-override branch from 72db8d8 to 4ff73bf Compare March 7, 2024 17:48
@matejvasek
Copy link
Collaborator

/approve
/lgtm

Copy link

openshift-ci bot commented Mar 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jrangelramos, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 7, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 098cb78 into openshift-knative:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants