Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instanciate new empty lists for each instance of WorkflowRepoManager #415

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Instanciate new empty lists for each instance of WorkflowRepoManager #415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions tests/functional/behave_features/common/utils/workflow_repo_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import logging
import git

from dataclasses import dataclass, field
from tempfile import TemporaryDirectory

import common.utils.github as github
Expand All @@ -14,15 +15,16 @@ class RepoManagementError(Exception):
pass


@dataclass
class WorkflowRepoManager:
# Keep a log of things created so we can clean them up.
__local_branches_created: [str] = []
__local_worktrees_created: [TemporaryDirectory] = []
__local_branches_created: list[str] = field(default_factory=list)
__local_worktrees_created: list[TemporaryDirectory] = field(default_factory=list)
# (remote, branch), e.g. ('openshift-helm-charts/charts, 'my-pr-branch')
__remote_branches_created: [(str, str)] = []
__remote_branches_created: list[(str, str)] = field(default_factory=list)

# The token to use for GitHub API operations.
__authtoken: str = ""
__authtoken: str = None

# The branch at repo initialization. On Cleanup, we return to this branch
# before we remove locally generated branches.
Expand All @@ -34,8 +36,8 @@ class WorkflowRepoManager:
# The repository at working directory.
repo: git.Repo = None

def __init__(self):
logging.debug(f"{self} --> __init__ called!")
def __post_init__(self):
logging.debug(f"{self} --> __post_init__ called!")

try:
self.repo = git.Repo()
Expand Down Expand Up @@ -94,6 +96,7 @@ def checkout_branch(self, branch_name: str):
self.repo.git.checkout("-b", branch_name)
except (git.GitCommandError, ValueError) as e:
raise RepoManagementError("Unable to create branch") from e
logging.debug(f'Adding {branch_name} to local_branches_created')
self.__local_branches_created.append(branch_name)

def add_worktree(self) -> TemporaryDirectory:
Expand Down
Loading