-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPL: Add json
function and cast(x as json)
function
#3243
Open
acarbonetto
wants to merge
30
commits into
opensearch-project:main
Choose a base branch
from
Bit-Quill:feature/acarbo_json_cast_ppl
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
PPL: Add json
function and cast(x as json)
function
#3243
acarbonetto
wants to merge
30
commits into
opensearch-project:main
from
Bit-Quill:feature/acarbo_json_cast_ppl
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acarbonetto
requested review from
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
mengweieric,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
GumpacG,
ykmr1224,
LantaoJin and
noCharger
as code owners
January 13, 2025 18:03
acarbonetto
force-pushed
the
feature/acarbo_json_cast_ppl
branch
2 times, most recently
from
January 15, 2025 18:33
2ccf4ab
to
3ec16e0
Compare
kenrickyap
reviewed
Jan 16, 2025
core/src/main/java/org/opensearch/sql/expression/json/JsonFunctions.java
Show resolved
Hide resolved
kenrickyap
reviewed
Jan 16, 2025
core/src/main/java/org/opensearch/sql/expression/operator/convert/TypeCastOperators.java
Show resolved
Hide resolved
kenrickyap
reviewed
Jan 16, 2025
kenrickyap
reviewed
Jan 16, 2025
core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java
Outdated
Show resolved
Hide resolved
kenrickyap
reviewed
Jan 16, 2025
core/src/test/java/org/opensearch/sql/expression/json/JsonFunctionsTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
….java Co-authored-by: Andrew Carbonetto <[email protected]> Signed-off-by: kenrickyap <[email protected]>
Signed-off-by: Kenrick Yap <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
acarbonetto
force-pushed
the
feature/acarbo_json_cast_ppl
branch
from
January 17, 2025 18:00
9347cad
to
ab9be75
Compare
Signed-off-by: Andrew Carbonetto <[email protected]>
Signed-off-by: Andrew Carbonetto <[email protected]>
kenrickyap
reviewed
Jan 21, 2025
kenrickyap
reviewed
Jan 21, 2025
core/src/test/java/org/opensearch/sql/expression/datetime/DateTimeFunctionTest.java
Outdated
Show resolved
Hide resolved
kenrickyap
reviewed
Jan 21, 2025
core/src/test/java/org/opensearch/sql/expression/datetime/YearweekTest.java
Outdated
Show resolved
Hide resolved
kenrickyap
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minor nits
Signed-off-by: Andrew Carbonetto <[email protected]>
kenrickyap
reviewed
Jan 21, 2025
kenrickyap
approved these changes
Jan 21, 2025
Signed-off-by: Andrew Carbonetto <[email protected]>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is dependent on the
json_valid
PR: #3230Description
For OpenSearch-PPL, adds the
json()
andcast(expression as json)
functions. Both of these functions can be used to convert a json-encoded string into an expression object. These functions return any expression type that is valid json (object, array, or scalar). Unfortunately, because the return type is unknown, the expression's return type isUNDEFINED
.The user can use
cast
to convert the types where necessary for scalar types. For example:The following casts are available to convert json-encoded scalars:
int
,long
,double
,float
,boolean
.Related Issues
Resolves #3209
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.