Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.18] Fix a regression issue of parsing datetime string with custom time format in Span (#3079) #3147

Open
wants to merge 2 commits into
base: 2.18
Choose a base branch
from
Open

[Backport 2.18] Fix a regression issue of parsing datetime string with custom time format in Span (#3079) #3147

wants to merge 2 commits into from

Conversation

LantaoJin
Copy link
Member

(cherry picked from commit 4ff1fe3)

@LantaoJin LantaoJin changed the title Fix a regression issue of parsing datetime string with custom time format in Span (#3079) [Backport 2.18] Fix a regression issue of parsing datetime string with custom time format in Span (#3079) Nov 1, 2024
ykmr1224
ykmr1224 requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@ykmr1224 ykmr1224 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing due to coverage.

@LantaoJin
fix coverage
dc42cc6 
Signed-off-by: Lantao Jin <[email protected]>
@LantaoJin
Copy link
Member Author

CI is failing due to coverage.

done

@LantaoJin
Copy link
Member Author

@ykmr1224 @dai-chen @YANG-DB @penghuo @seankao-az is this patch available to present in 2.18.0? or only in 2.18.1?

@Swiddis Swiddis requested a review from ykmr1224 November 6, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dai-chen dai-chen dai-chen approved these changes

@Swiddis Swiddis Swiddis approved these changes

@ps48 ps48 Awaiting requested review from ps48 ps48 is a code owner

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@derek-ho derek-ho Awaiting requested review from derek-ho derek-ho is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@YANG-DB YANG-DB Awaiting requested review from YANG-DB YANG-DB is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@vamsi-amazon vamsi-amazon Awaiting requested review from vamsi-amazon vamsi-amazon is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz MaxKsyunz is a code owner

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

@forestmvey forestmvey Awaiting requested review from forestmvey forestmvey is a code owner

@acarbonetto acarbonetto Awaiting requested review from acarbonetto acarbonetto is a code owner

@GumpacG GumpacG Awaiting requested review from GumpacG GumpacG is a code owner

@ykmr1224 ykmr1224 Awaiting requested review from ykmr1224 ykmr1224 is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LantaoJin @ykmr1224 @Swiddis @dai-chen