[Backport 2.x] fix(deps): update dependency com.google.guava:guava to v33 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
dbwiddis
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
xinyual,
amitgalitz,
jackiehanyang,
owaiskazi19,
ohltyler,
joshpalis,
kaituo,
lezzago,
eirsep,
sbcd90 and
zhichao-aws
as code owners
Signed-off-by: mend-for-github-com[bot] <mend-for-github-com[bot]@users.noreply.github.com>
ohltyler
approved these changes
Dec 22, 2023
|
Please fix the conflicts. |
Hailong-am
reviewed
Dec 26, 2023
| @@ -104,7 +104,7 @@ dependencies { | |||
| compileOnly "org.apache.logging.log4j:log4j-slf4j-impl:2.22.0" | |||
| compileOnly group: 'org.json', name: 'json', version: '20231013' | |||
| zipArchive group: 'org.opensearch.plugin', name:'opensearch-sql-plugin', version: "${version}" | |||
| implementation("com.google.guava:guava:32.1.3-jre") | |||
| implementation("com.google.guava:guava:33.0.0-jre") | |||
There was a problem hiding this comment.
Question about this update, skills depends on ml-commons, ml-common use different version of guava, it will cause jar hell exception when OpenSearch start
There was a problem hiding this comment.
In #38 it uses compileOnly, we should be consistent about this
There was a problem hiding this comment.
@dbwiddis can you help change this to compileOnly?
|
Closing this as the changes have been made in other PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports ebeb4c5 from #38