Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove search index tool #295

Merged
merged 6 commits into from
Apr 26, 2024

Conversation

yuye-aws
Copy link
Member

@yuye-aws yuye-aws commented Apr 24, 2024

Description

Remove search index tool in the current repo: #294

Issues Resolved

Remove search index tool in the current repo: #294

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (02a3209) to head (291de19).
Report is 2 commits behind head on main.

❗ Current head 291de19 differs from pull request most recent head 148df73. Consider uploading reports for the commit 148df73 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #295      +/-   ##
============================================
+ Coverage     81.62%   82.33%   +0.71%     
+ Complexity      216      200      -16     
============================================
  Files            13       12       -1     
  Lines          1083     1019      -64     
  Branches        149      142       -7     
============================================
- Hits            884      839      -45     
+ Misses          140      125      -15     
+ Partials         59       55       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuye-aws
Copy link
Member Author

@ylwu-amzn Please help attach backport 2.x label.

@yuye-aws
Copy link
Member Author

@yuye-aws This PR is ready for review now.

@ylwu-amzn
Copy link
Collaborator

@yuye-aws CI failed, fix it?

@yuye-aws yuye-aws force-pushed the RemoveSearchIndexTool branch from ebc4836 to 148df73 Compare April 25, 2024 05:07
@yuye-aws
Copy link
Member Author

yuye-aws commented Apr 25, 2024

@yuye-aws CI failed, fix it?

Adding a new commit to fix the CI error. You can review now.

@yuye-aws
Copy link
Member Author

Please merge this PR after this one: opensearch-project/ml-commons#2356

@ylwu-amzn ylwu-amzn merged commit 0e65e62 into opensearch-project:main Apr 26, 2024
16 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/skills/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/skills/backport-2.x
# Create a new branch
git switch --create backport/backport-295-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0e65e621137b0fbb7629ffd222dce1b300b241b4
# Push it to GitHub
git push --set-upstream origin backport/backport-295-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/skills/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-295-to-2.x.

yuye-aws added a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
* remove search index tool

Signed-off-by: yuye-aws <[email protected]>

* remove search index tool integration tests

Signed-off-by: yuye-aws <[email protected]>

* make processResponse private

Signed-off-by: yuye-aws <[email protected]>

* remove json file for search index tool it

Signed-off-by: yuye-aws <[email protected]>

* remove json file for search index tool ut

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove json file for search index tool ut"

This reverts commit 1db72bb.

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
(cherry picked from commit 0e65e62)
yuye-aws added a commit to yuye-aws/skills that referenced this pull request Apr 26, 2024
* remove search index tool

Signed-off-by: yuye-aws <[email protected]>

* remove search index tool integration tests

Signed-off-by: yuye-aws <[email protected]>

* make processResponse private

Signed-off-by: yuye-aws <[email protected]>

* remove json file for search index tool it

Signed-off-by: yuye-aws <[email protected]>

* remove json file for search index tool ut

Signed-off-by: yuye-aws <[email protected]>

* Revert "remove json file for search index tool ut"

This reverts commit 1db72bb.

Signed-off-by: yuye-aws <[email protected]>

---------

Signed-off-by: yuye-aws <[email protected]>
(cherry picked from commit 0e65e62)
Signed-off-by: yuye-aws <[email protected]>
@yuye-aws yuye-aws deleted the RemoveSearchIndexTool branch November 21, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants