Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Health Status of security-auditlog Index in Single Node Clusters #5030
base: main
Are you sure you want to change the base?
Improve Health Status of security-auditlog Index in Single Node Clusters #5030
Changes from 1 commit
5939aa0
0bceb07
64eb14b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this could be moved to common/utils class.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't
lastUsedIndexName
be set here?What happens in the case of node reboot and the audit log index exists?
lastUsedIndexName
would be null when the node starts. Shouldn't thiscatch
clause be used to populate it if it is null and the index already exists?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI I experimented around with passing the
clusterService
to the internal opensearch sinks which can be used to check if an index exists without having to issue an Exists request. Take a look at the change on my fork cwperks#44. That change also shows an example of how to use the integration test framework in this repo to write an integration test for this case.