Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jvmGCTime metrics #889

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Conversation

ykmr1224
Copy link
Collaborator

@ykmr1224 ykmr1224 commented Nov 11, 2024

Description

  • Add jvmGCTime metriccs (unit is in Milliseconds)
  • emit per task metrics and total for query
  • Renamed ReadWriteBytesSparkListener to MetricsSparkListener to handle multiple metrics

Test result:
Metrics-CloudWatch-us-east-1-11-11-2024_02_53_PM

Related Issues

n/a

Check List

  • Updated documentation (docs/ppl-lang/README.md)
  • Implemented unit tests
  • Implemented tests for combination with other commands
  • New added source code should include a copyright header
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: Tomoyuki Morita <[email protected]>
@penghuo penghuo added the 0.6 label Nov 13, 2024
Copy link
Collaborator

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx!

@ykmr1224 ykmr1224 merged commit cbcab2f into opensearch-project:main Nov 13, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Add jvmGCTime metrics

Signed-off-by: Tomoyuki Morita <[email protected]>

* Fix style

Signed-off-by: Tomoyuki Morita <[email protected]>

---------

Signed-off-by: Tomoyuki Morita <[email protected]>
(cherry picked from commit cbcab2f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ykmr1224 pushed a commit that referenced this pull request Nov 13, 2024
* Add jvmGCTime metrics



* Fix style



---------


(cherry picked from commit cbcab2f)

Signed-off-by: Tomoyuki Morita <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants