Update developer guide to remove incorrect command line option #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Widdis <[email protected]>
dbwiddis
requested review from
joshpalis,
owaiskazi19,
ryanbogan and
saratvemulapalli
as code owners
saratvemulapalli
approved these changes
Aug 2, 2023
joshpalis
approved these changes
Aug 2, 2023
saratvemulapalli
merged commit eef11b0
into
opensearch-project:main
7 of 8 checks passed
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit eef11b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 2, 2023
Signed-off-by: Daniel Widdis <[email protected]> (cherry picked from commit eef11b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli
pushed a commit
that referenced
this pull request
Aug 2, 2023
…922) (cherry picked from commit eef11b0) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
saratvemulapalli
pushed a commit
that referenced
this pull request
Aug 2, 2023
…921) (cherry picked from commit eef11b0) Signed-off-by: Daniel Widdis <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Gradle tasks don't pass arguments as system properties without taking extra steps to do so.
This removes a line documenting an incorrect command line option from the developer guide.
Issues Resolved
Fixes #916
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.