Added canary url and stepfunction monitoring with sns email and slack… #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
============================================
+ Coverage 73.49% 76.64% +3.15%
- Complexity 163 174 +11
============================================
Files 43 51 +8
Lines 962 1122 +160
Branches 47 50 +3
============================================
+ Hits 707 860 +153
- Misses 234 239 +5
- Partials 21 23 +2 ☔ View full report in Codecov by Sentry. |
bshien
force-pushed
the
monitoring-6
branch
2 times, most recently
from
6eebc5e
to
7bb028e
Compare
… integration Signed-off-by: Brandon Shien <[email protected]>
bshien
commented
Jun 7, 2024
|
|
||
| // The email list for receiving alerts | ||
| this.emailList = [ | ||
| '[email protected]' |
bshien
commented
Jun 7, 2024
infrastructure/lib/stacks/secrets.ts
Outdated
| constructor(scope: Construct, id: string) { | ||
| super(scope, id); | ||
| this.secretsObject = new Secret(this, 'MetricsCreds', { | ||
| secretName: 'metrics-creds', |
There was a problem hiding this comment.
input from project.ts
bshien
commented
Jun 7, 2024
infrastructure/lib/stacks/secrets.ts
Outdated
| import {Secret} from "aws-cdk-lib/aws-secretsmanager"; | ||
|
|
||
| export class OpenSearchMetricsSecrets extends Stack { | ||
| readonly secretsObject: Secret; |
bshien
commented
Jun 7, 2024
| package org.opensearchmetrics.datasource; | ||
|
|
||
| public enum DataSourceType { | ||
| SLACK_WEBHOOK_URL, |
bshien
commented
Jun 7, 2024
| @JsonProperty("AlarmName") | ||
| private String alarmName; | ||
| @JsonProperty("AlarmDescription") | ||
| private String alarmDescription; |
| private String region; | ||
| @JsonProperty("AlarmArn") | ||
| private String alarmArn; | ||
| } |
There was a problem hiding this comment.
Move this AlarmObject to model/alarm package.
bshien
force-pushed
the
monitoring-6
branch
2 times, most recently
from
fe78734
to
ddc3fe3
Compare
build.gradle
Outdated
| @@ -28,6 +28,7 @@ dependencies { | |||
| implementation 'io.github.acm19:aws-request-signing-apache-interceptor:2.3.1' | |||
|
|
|||
| implementation 'com.amazonaws:aws-lambda-java-core:1.2.3' | |||
| implementation 'com.amazonaws:aws-lambda-java-events:3.7.0' | |||
There was a problem hiding this comment.
The latest one is 3.11.5, can you please update ?
prudhvigodithi
approved these changes
Jun 10, 2024
|
LGTM, thanks @bshien. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… integration
Description
Creates a Cloudwatch Synthetic Canary to monitor the metrics.opensearch.org url and monitors the step functions for failure. If either of these fail, a message will be published to SNS, and will send email and slack notifications.
Issues Resolved
#37
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.