Skip to content

Commit

Permalink
Changed Canary alarm threshold from 100 to 50 (#44)
Browse files Browse the repository at this point in the history
Signed-off-by: Brandon Shien <[email protected]>
  • Loading branch information
bshien authored Jun 25, 2024
1 parent 204c575 commit 21ca56a
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 12 deletions.
2 changes: 1 addition & 1 deletion infrastructure/lib/constructs/canarySns.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ export class canarySns extends SnsMonitors {
private canaryFailed(alertName: string, canary: Canary): [Alarm, string] {
const alarmObject = new cloudwatch.Alarm(this, `error_alarm_${alertName}`, {
metric: canary.metricSuccessPercent(),
threshold: 100,
threshold: 50,
evaluationPeriods: 1,
comparisonOperator: cloudwatch.ComparisonOperator.LESS_THAN_THRESHOLD,
datapointsToAlarm: 1,
Expand Down
21 changes: 11 additions & 10 deletions infrastructure/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion infrastructure/test/monitoring-stack.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ test('Monitoring Stack Test', () => {
"Namespace": "CloudWatchSynthetics",
"Period": 300,
"Statistic": "Average",
"Threshold": 100,
"Threshold": 50,
"TreatMissingData": "notBreaching"
});
});

0 comments on commit 21ca56a

Please sign in to comment.