Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an example for bulk update operation #690

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

karthiks3000
Copy link
Contributor

Description

Updating the Bulk example to also showcase bulk update operations. Moved duplicate code into re-usable methods.

Issues Resolved

Closes 590

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Karthik Subramanian <[email protected]>
Signed-off-by: Karthik Subramanian <[email protected]>
Signed-off-by: Karthik Subramanian <[email protected]>
Signed-off-by: Karthik Subramanian <[email protected]>
Signed-off-by: Karthik Subramanian <[email protected]>
Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @karthiks3000 !

@VachaShah VachaShah merged commit 25bd4cf into opensearch-project:main Oct 27, 2023
31 checks passed
@VachaShah VachaShah added the backport 2.x Backport to 2.x branch label Oct 27, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-690-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25bd4cf19dc2bd7e31596865cf75f031104d6dfa
# Push it to GitHub
git push --set-upstream origin backport/backport-690-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-690-to-2.x.

@VachaShah
Copy link
Collaborator

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-690-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 25bd4cf19dc2bd7e31596865cf75f031104d6dfa
# Push it to GitHub
git push --set-upstream origin backport/backport-690-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-690-to-2.x.

Might be failing since #687 first needs to be backported to 2.x. Will re-trigger this once that is done.

@VachaShah VachaShah added backport 2.x Backport to 2.x branch and removed backport 2.x Backport to 2.x branch labels Oct 27, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 27, 2023
* Adding an example for bulk update operation

Signed-off-by: Karthik Subramanian <[email protected]>

* updated the changelog.md

Signed-off-by: Karthik Subramanian <[email protected]>

* changes made by spotlessApply

Signed-off-by: Karthik Subramanian <[email protected]>

* removing CommonUtil based on review comments

Signed-off-by: Karthik Subramanian <[email protected]>

* reverting files to original state

Signed-off-by: Karthik Subramanian <[email protected]>

* changes by spotlessApply

Signed-off-by: Karthik Subramanian <[email protected]>

* removing static fields and unnecessary waits

Signed-off-by: Karthik Subramanian <[email protected]>

* changes as per review comments

Signed-off-by: Karthik Subramanian <[email protected]>

* removing unnecessary changes

Signed-off-by: Karthik Subramanian <[email protected]>

---------

Signed-off-by: Karthik Subramanian <[email protected]>
(cherry picked from commit 25bd4cf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Oct 27, 2023
* Adding an example for bulk update operation



* updated the changelog.md



* changes made by spotlessApply



* removing CommonUtil based on review comments



* reverting files to original state



* changes by spotlessApply



* removing static fields and unnecessary waits



* changes as per review comments



* removing unnecessary changes



---------


(cherry picked from commit 25bd4cf)

Signed-off-by: Karthik Subramanian <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrendonFaleiro BrendonFaleiro mentioned this pull request Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: a bulk request with Update operation for existing document results in 400 Bad request
3 participants