Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make distribution optional in version info #594

Closed
wants to merge 1 commit into from

Conversation

jhg023
Copy link

@jhg023 jhg023 commented Aug 4, 2023

Description

No longer require distribution in OpenSearchVersionInfo to be non-null.

Issues Resolved

Closes #573

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Collaborator

@reta reta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross posting from the issue. @jhg023 @wbeckler the distribution is a required property returned by the OpenSearch server, the issue looks to be AWS specific. The server/client API model is correct.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold this until we figured out whether this is a bug in AWS.

@dblock
Copy link
Member

dblock commented Aug 7, 2023

This is by design with compatibility mode enabled, see #573 (comment). Thanks for bringing this up @jhg023!

@dblock dblock closed this Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants