-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Add integration test cases for workspace assets. #1639
Open
SuZhou-Joe
wants to merge
5
commits into
opensearch-project:main
Choose a base branch
from
SuZhou-Joe:feature/workspace_assets_ft
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[workspace] Add integration test cases for workspace assets. #1639
SuZhou-Joe
wants to merge
5
commits into
opensearch-project:main
from
SuZhou-Joe:feature/workspace_assets_ft
+184
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuZhou-Joe
requested review from
tianleh,
kavilla,
ohltyler,
CCongWang,
ashwin-pc,
peterzhuamazon,
ananzh,
prudhvigodithi,
xluo-aws,
Hailong-am,
ruanyl,
wanglam,
raintygao,
zhongnansu and
yujin-emma
as code owners
November 13, 2024 10:08
SuZhou-Joe
force-pushed
the
feature/workspace_assets_ft
branch
from
November 13, 2024 10:13
454bc3c
to
7a355f2
Compare
Hailong-am
approved these changes
Nov 15, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Outdated
Show resolved
Hide resolved
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Show resolved
Hide resolved
raintygao
reviewed
Nov 15, 2024
if (Cypress.env('DATASOURCE_MANAGEMENT_ENABLED')) { | ||
cy.createDataSourceNoAuth().then((result) => { | ||
datasourceId = result[0]; | ||
expect(datasourceId).to.be.a('string').that.is.not.empty; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used to verify the data source creation successfully?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, from API side.
raintygao
reviewed
Nov 15, 2024
...re-opensearch-dashboards/opensearch-dashboards/workspace-plugin/mds_workspace_assets.spec.js
Show resolved
Hide resolved
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
Signed-off-by: SuZhou-Joe <[email protected]>
SuZhou-Joe
force-pushed
the
feature/workspace_assets_ft
branch
from
November 15, 2024 09:59
b4a7ee2
to
c29c2f6
Compare
raintygao
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add integration test cases for workspace assets.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.