-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed alerting cypress tests. #1451
Fixed alerting cypress tests. #1451
Conversation
Signed-off-by: AWSHurneyt <[email protected]>
Suppose the failure should be flaky, let me rerun the alerting test. |
@SuZhou-Joe Actually, could you remove the 2.13-2.15 backport labels? We don't need to backport these fixes that far. Sorry! |
@AWSHurneyt Sure, but the |
@SuZhou-Joe |
@SuZhou-Joe I have seen in the past that CIs here fail but they are passing in our repo CIs as well as the release test passes, so I think we should be fine merging this change to unblock 2.16 and only spend time investigating if the auto cut issue is not resolved |
@amsiglan @AWSHurneyt I see, I will take your manual sign-off to unblock the 2.16 release. Create an issue #1464 to track. |
Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 86599cf)
Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 86599cf)
Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 86599cf) Co-authored-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> (cherry picked from commit 86599cf) Co-authored-by: AWSHurneyt <[email protected]>
Description
Fixed cypress tests following PR opensearch-project/alerting#1612
Please backport this PR to 2.x, and 2.13 through 2.16.
Testing
Corresponding PR in the plugin repo that shows the tests pass with security disabled - opensearch-project/alerting-dashboards-plugin#1027
Ran the tests on a security enabled docker domain. Had to run some test suites in chunks as they were running slow on my local machine.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.