add functional test for sidecar #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raintygao
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl and
wanglam
as code owners
7 tasks
Signed-off-by: tygao <[email protected]>
Signed-off-by: tygao <[email protected]>
wanglam
reviewed
Mar 19, 2024
| cy.get('.llm-chat-flyout button[aria-label="fullScreen"]').click(); | ||
| it('should hide back button in takeover fullscreen mode', () => { | ||
| //switch to takeover mode for fullscreen | ||
| cy.get('[id="sidecarModeIcon"]').click(); |
There was a problem hiding this comment.
Shall we change to cy.get("#sidecarModeIcon")?
There was a problem hiding this comment.
I think both ways are OK.
Hailong-am
reviewed
Mar 19, 2024
cypress/integration/plugins/dashboards-assistant/chatbot_sidecar_spec.js
Outdated
Show resolved
Hide resolved
Hailong-am
approved these changes
Mar 19, 2024
…ar_spec.js Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: tygao <[email protected]>
SuZhou-Joe
approved these changes
Mar 20, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add function test for sidecar Signed-off-by: tygao <[email protected]> * test: update tests for sidecar integration Signed-off-by: tygao <[email protected]> * Update cypress/integration/plugins/dashboards-assistant/chatbot_sidecar_spec.js Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 4cd28e2)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Mar 20, 2024
* add function test for sidecar Signed-off-by: tygao <[email protected]> * test: update tests for sidecar integration Signed-off-by: tygao <[email protected]> * Update cypress/integration/plugins/dashboards-assistant/chatbot_sidecar_spec.js Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 4cd28e2)
raintygao
added a commit
that referenced
this pull request
Mar 20, 2024
* add function test for sidecar Signed-off-by: tygao <[email protected]> * test: update tests for sidecar integration Signed-off-by: tygao <[email protected]> * Update cypress/integration/plugins/dashboards-assistant/chatbot_sidecar_spec.js Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 4cd28e2) Co-authored-by: tygao <[email protected]>
raintygao
added a commit
that referenced
this pull request
Mar 20, 2024
* add function test for sidecar Signed-off-by: tygao <[email protected]> * test: update tests for sidecar integration Signed-off-by: tygao <[email protected]> * Update cypress/integration/plugins/dashboards-assistant/chatbot_sidecar_spec.js Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: tygao <[email protected]> --------- Signed-off-by: tygao <[email protected]> Co-authored-by: Hailong Cui <[email protected]> (cherry picked from commit 4cd28e2) Co-authored-by: tygao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add functional test for sidecar.
This functional test should run on the feat-sidecar branch of OSD and dashboard-assistant repo, so checks may fail in CI env.
Following is the recording and result of tests.
recording.mp4
Issues Resolved
Depend on OSD PR: opensearch-project/OpenSearch-Dashboards#5920
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.