Support MacOS13 x64/arm64 Agents Packer Templates on EC2 #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
requested review from
gaiksaya,
rishabh6788,
zelinh,
prudhvigodithi and
Divyaasm
as code owners
Signed-off-by: Peter Zhu <[email protected]>
prudhvigodithi
approved these changes
Jul 12, 2024
|
Thanks @peterzhuamazon moving forward we dont need macos-disk-resize.sh anymore, should we move this to legacy ? |
| @@ -1,5 +1,5 @@ | |||
| export PATH=/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:$PATH | |||
| export PATH=/opt/local/bin:$PATH | |||
| export PATH=/opt/homebrew/bin:/opt/local/bin:$PATH | |||
There was a problem hiding this comment.
Since this bashrc works for legacy jenkins-agent-macos12-x64.json , should we move this to legacy folder as well?
There was a problem hiding this comment.
This also works for the new macos13 that is why I keep it here.
Thanks.
I will keep this for a bit as I am still not 100 percent sure the resizing is consistent. Thanks. |
|
Mend scan failure unrelated to the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support MacOS13 x64/arm64 Packer Building EC2 AMI
Issues Resolved
opensearch-project/opensearch-build#4670
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.