Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smoke tests to the test manifest schema #5127

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Add smoke tests to the test manifest schema #5127

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
053cf63
Add smoke tests to the test manifst schema
zelinh Oct 22, 2024
2d18799
Update the spec to string
zelinh Oct 31, 2024
60b844f
Change example to yml
zelinh Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/manifests/test_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']):
- with-security
- without-security
smoke-test:
test-spec:
- spec.yaml
test-spec: spec.yaml
Copy link
Member

@peterzhuamazon peterzhuamazon Oct 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep it consistent here?
.yaml or .yml?

Thanks.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure updated to .yml.

"""

SCHEMA = {
Expand Down Expand Up @@ -94,7 +93,7 @@ class TestManifest(ComponentManifest['TestManifest', 'TestComponents']):
"smoke-test": {
"type": "dict",
"schema": {
"test-spec": {"type": "list"},
"test-spec": {"type": "string"},
},
},
},
Expand Down
3 changes: 1 addition & 2 deletions tests/tests_manifests/data/opensearch-2.18.0-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ ci:
components:
- name: opensearch
smoke-test:
test-spec:
- opensearch.yml
test-spec: opensearch.yml
- name: alerting
integ-test:
test-configs:
Expand Down
2 changes: 1 addition & 1 deletion tests/tests_manifests/test_test_manifest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def test_component(self) -> None:
self.assertEqual(component_as.bwc_test, {"test-configs": ["with-security"]})
component_os = self.manifest.components["opensearch"]
self.assertEqual(component_os.name, "opensearch")
self.assertEqual(component_os.smoke_test, {"test-spec": ["opensearch.yml"]})
self.assertEqual(component_os.smoke_test, {"test-spec": "opensearch.yml"})

def test_component_with_working_directory(self) -> None:
component = self.manifest.components["notifications"]
Expand Down
Loading