Fix manifest file escaping in URLs #4660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a reproducer test for #4656 based on my best understanding of the inputs that led to the bug, and updates the code to fix it with more robust join logic. Some other whitespace updates got mangled in due to autoformatting, can filter them back out if necessary.
A cleaner alternative may be to go back to using
os.path.join
and replacing\\
with/
, but could still run into issues if the input strings already have backslashes.urllib.parse.urljoin
frustratingly does not actually join URLs (it cuts away path components), so as far as I can tell using.strip('/')
everywhere is the best way to merge URLs.Issues Resolved
Resolves #4656
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.