Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Test Report logger broke for OpenSearch Dashboards. #4943

Closed
prudhvigodithi opened this issue Aug 13, 2024 · 2 comments
Closed

[Bug]: Test Report logger broke for OpenSearch Dashboards. #4943

prudhvigodithi opened this issue Aug 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@prudhvigodithi
Copy link
Member

Describe the bug

Coming from opensearch-project/opensearch-dashboards-functional-test#1411 and #4796 after adding the ci-groups changes for OSD tests, the test report logger for OSD tests shows as not available this is because of the component name is no longer as OpenSearch-Dashboards.

Example the OpenSearch-Dashboards-ci-group-6 the log is now generated with the URL link https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/linux/arm64/tar/test-results/6200/integ-test/OpenSearch-Dashboards-ci-group-6/with-security/OpenSearch-Dashboards-ci-group-6.yml and not as https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/linux/arm64/tar/test-results/6200/integ-test/OpenSearch-Dashboards/with-security/OpenSearch-Dashboards.yml.

With this not available the same data is now indexed to the Metrics Cluster showing as not available

Screenshot 2024-08-13 at 11 29 28 AM

To reproduce

Here is the real sample data https://build.ci.opensearch.org/job/integ-test-opensearch-dashboards/6248/artifact/test-report.yml that has Not Available

components:
  - name: OpenSearch-Dashboards
    command: ./test.sh integ-test manifests/2.16.0/opensearch-dashboards-2.16.0-test.yml
      --paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.16.0/10150/windows/x64/zip
      opensearch-dashboards=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/2.16.0/7858/windows/x64/zip
      --component OpenSearch-Dashboards
    configs:
      - name: with-security
        status: Not Available
        yml: URL not available
        cluster_stdout:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-0/stdout.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-1/stdout.txt
        cluster_stderr:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-0/stderr.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-1/stderr.txt
      - name: without-security
        status: Not Available
        yml: URL not available
        cluster_stdout:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-2/stdout.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-3/stdout.txt
        cluster_stderr:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-2/stderr.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7858/windows/x64/zip/test-results/6248/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-3/stderr.txt

Expected behavior

The generated test report for OpenSearch Dashboards should:

  • Either for OpenSearch-Dashboards to have a sub-component level for each ci-group and then with the same flow showing with-security and without-security data. During indexing to metrics cluster update the indexer library (publishIntegTestResults) to accommodate this change.
  • Instead of sub-component, treat each of the ci-group as an individual component and add it to the test manifest. This will ensure the (publishIntegTestResults) indexes as each component (Example OpenSearch-Dashboards-ci-group-6 OpenSearch-Dashboards-ci-group-5 etc) and creates visualizations to ensure the results of OpenSearch-Dashboards summarizes all ci-groups.

Screenshots

If applicable, add screenshots to help explain your problem.

Host / Environment

No response

Additional context

No response

Relevant log output

No response

@prudhvigodithi prudhvigodithi added bug Something isn't working untriaged Issues that have not yet been triaged labels Aug 13, 2024
@gaiksaya gaiksaya removed the untriaged Issues that have not yet been triaged label Aug 15, 2024
@zelinh
Copy link
Member

zelinh commented Aug 19, 2024

I would prefer the second approach here that we treat each of ci group as individual component. This would not change the schema for the report manifest and keep the impact radius minimum.

I will take care of this issue.

@zelinh zelinh self-assigned this Aug 19, 2024
@bshien bshien moved this from Now(This Quarter) to ✅ Done in Engineering Effectiveness Board Aug 26, 2024
@zelinh
Copy link
Member

zelinh commented Sep 3, 2024

Close this issue as this has been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

No branches or pull requests

3 participants