Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Filter the OSD integration tests with component OpenSearch-Dashboards #72

Closed
prudhvigodithi opened this issue Sep 10, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@prudhvigodithi
Copy link
Member

Is your feature request related to a problem?

Coming from the issue opensearch-project/opensearch-build#4943, the integration tests for OpenSearch-Dashboards is now saved at group level, meaning the component name is not direct OpenSearch-Dashboards but as OpenSearch-Dashboards-ci-group-6 etc. With this in the test manifest when we index the test results to the metrics cluster the component name is also as OpenSearch-Dashboards-ci-group-6 and not direct OpenSearch-Dashboards.

What solution would you like?

Have a mechanism to filter with component as OpenSearch-Dashboards still honoring filter per group level. This was when filtered with OpenSearch-Dashboards should directly give all the CI group results.

What alternatives have you considered?

A clear and concise description of any alternative solutions or features you've considered.

Do you have any additional context?

Add any other context or screenshots about the feature request here.

@prudhvigodithi prudhvigodithi added enhancement New feature or request untriaged Issues that have not yet been triaged labels Sep 10, 2024
@prudhvigodithi
Copy link
Member Author

prudhvigodithi commented Sep 12, 2024

[Triage]
We need have a value just for OpenSearch-Dashboards to be able to filter as component.keyword as OpenSearch-Dashboards. More details in Dashboard link.

@prudhvigodithi
Copy link
Member Author

Since ci-group's are not implemented generically across all components, but only for OpenSearch Dashboards (as seen in this PR and this PR), the solution is to include the component_repo keyword in the documents. This will allow filtering by repository, such as OpenSearch-Dashboards, to retrieve all relevant documents containing this keyword and display the ci-group's results. Adding a ci_group field is not the right solution, as ci-group's are only applicable to OpenSearch Dashboards and not other repositories. With the component_repo filter, we can make this functionality generic, applying it to any repository, regardless of whether it has CI groups or not.
Thanks
@peterzhuamazon @getsaurabh02

@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Engineering Effectiveness Board Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

No branches or pull requests

2 participants