-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring var scopes in uploadMinSnapshotsToS3 libs #318
Merged
peterzhuamazon
merged 6 commits into
opensearch-project:main
from
peterzhuamazon:uploadMinSnapshotsToS3_var_scopes
Oct 4, 2023
Merged
Refactoring var scopes in uploadMinSnapshotsToS3 libs #318
peterzhuamazon
merged 6 commits into
opensearch-project:main
from
peterzhuamazon:uploadMinSnapshotsToS3_var_scopes
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
added
bug
Something isn't working
enhancement
New feature or request
backport 5.x
labels
Sep 19, 2023
peterzhuamazon
requested review from
gaiksaya and
rishabh6788
as code owners
September 19, 2023 17:19
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
=========================================
Coverage 87.37% 87.37%
Complexity 29 29
=========================================
Files 80 80
Lines 206 206
Branches 11 11
=========================================
Hits 180 180
Misses 19 19
Partials 7 7
|
zelinh
reviewed
Sep 19, 2023
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
peterzhuamazon
force-pushed
the
uploadMinSnapshotsToS3_var_scopes
branch
from
October 3, 2023 21:06
5e70ae2
to
dacd6c8
Compare
zelinh
reviewed
Oct 3, 2023
gaiksaya
reviewed
Oct 3, 2023
Signed-off-by: Peter Zhu <[email protected]>
gaiksaya
approved these changes
Oct 4, 2023
zelinh
reviewed
Oct 4, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-5.x 5.x
# Navigate to the new working tree
pushd ../.worktrees/backport-5.x
# Create a new branch
git switch --create backport/backport-318-to-5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5575d7075690e32a16b04c7c7457ad688176eaad
# Push it to GitHub
git push --set-upstream origin backport/backport-318-to-5.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-5.x Then, create a pull request where the |
peterzhuamazon
added a commit
to peterzhuamazon/opensearch-build-libraries
that referenced
this pull request
Oct 4, 2023
…ject#318) Signed-off-by: Peter Zhu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refactoring var scopes in uploadMinSnapshotsToS3 libs
Issues Resolved
Closes #319
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.