Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring var scopes in uploadMinSnapshotsToS3 libs #318

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Sep 19, 2023

Description

Refactoring var scopes in uploadMinSnapshotsToS3 libs

Issues Resolved

Closes #319

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #318 (04cd9ca) into main (63eb337) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #318   +/-   ##
=========================================
  Coverage     87.37%   87.37%           
  Complexity       29       29           
=========================================
  Files            80       80           
  Lines           206      206           
  Branches         11       11           
=========================================
  Hits            180      180           
  Misses           19       19           
  Partials          7        7           
Files Coverage Δ
...ts/jenkins/jobs/uploadMinSnapshotsToS3_Jenkinsfile 100.00% <ø> (ø)

Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon force-pushed the uploadMinSnapshotsToS3_var_scopes branch from 5e70ae2 to dacd6c8 Compare October 3, 2023 21:06
vars/uploadMinSnapshotsToS3.groovy Show resolved Hide resolved
vars/uploadMinSnapshotsToS3.groovy Outdated Show resolved Hide resolved
vars/uploadMinSnapshotsToS3.groovy Outdated Show resolved Hide resolved
vars/uploadMinSnapshotsToS3.groovy Outdated Show resolved Hide resolved
Signed-off-by: Peter Zhu <[email protected]>
@peterzhuamazon peterzhuamazon merged commit 5575d70 into opensearch-project:main Oct 4, 2023
7 checks passed
@peterzhuamazon peterzhuamazon deleted the uploadMinSnapshotsToS3_var_scopes branch October 4, 2023 19:41
@opensearch-trigger-bot
Copy link

The backport to 5.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-5.x 5.x
# Navigate to the new working tree
pushd ../.worktrees/backport-5.x
# Create a new branch
git switch --create backport/backport-318-to-5.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 5575d7075690e32a16b04c7c7457ad688176eaad
# Push it to GitHub
git push --set-upstream origin backport/backport-318-to-5.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-5.x

Then, create a pull request where the base branch is 5.x and the compare/head branch is backport/backport-318-to-5.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 5.x bug Something isn't working enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

[BUG] s3upload weirdly switch architecture value during upload sha512 for snapshots
3 participants