Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return for build Failure messages #275

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

gaiksaya
Copy link
Member

Description

In case of no string found the message should return null. This PR fixes the same.

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Sayali Gaikawad <[email protected]>
@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #275 (28f9cd2) into main (8cede32) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #275   +/-   ##
=========================================
  Coverage     86.63%   86.63%           
  Complexity       27       27           
=========================================
  Files            77       77           
  Lines           202      202           
  Branches         11       11           
=========================================
  Hits            175      175           
  Misses           19       19           
  Partials          8        8           

@gaiksaya gaiksaya merged commit f184ed3 into opensearch-project:main Aug 15, 2023
7 checks passed
@gaiksaya gaiksaya deleted the error branch August 15, 2023 21:45
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 15, 2023
Signed-off-by: Sayali Gaikawad <[email protected]>
(cherry picked from commit f184ed3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants