-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing api keys from the integ test log #3112
Conversation
Signed-off-by: Dhrubo Saha <[email protected]>
Signed-off-by: Dhrubo Saha <[email protected]>
Don't you need to do this for all integ tests that use connectors? |
Signed-off-by: Dhrubo Saha <[email protected]>
Yeah, agree. Now I added that try catch block in the |
|
||
} | ||
|
||
private static String maskSensitiveInfo(String input) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor: can add a simple test case for this
} | ||
|
||
public void testGetConnector() throws IOException { | ||
public void testCreate_Get_DeleteConnector() throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we have combined the 3 api calls, does the error message give enough information to validate at which step (create, get, delete) the test failed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If any assertion fails, it will indicate which assertion is failing within the method, correct? I’ve noticed a lot of redundant resource creation in this integration test class, which I plan to remove step by step. In this case, we are now creating the connector resource once and reusing it for three tests, rather than creating the resource three separate times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, i misunderstood the change - assumed it was a connection test to the connector itself during creation phase via API and not integ tests. Thanks for clearing this up!
Signed-off-by: Dhrubo Saha <[email protected]>
* removing api keys from the integ test log Signed-off-by: Dhrubo Saha <[email protected]> * apply spotless Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> * adding unit test to address comments Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit bc030fa)
* removing api keys from the integ test log Signed-off-by: Dhrubo Saha <[email protected]> * apply spotless Signed-off-by: Dhrubo Saha <[email protected]> * addressed comment Signed-off-by: Dhrubo Saha <[email protected]> * adding unit test to address comments Signed-off-by: Dhrubo Saha <[email protected]> --------- Signed-off-by: Dhrubo Saha <[email protected]> (cherry picked from commit bc030fa) Co-authored-by: Dhrubo Saha <[email protected]>
Description
[removing api keys from the integ test log
Solving this issue: #2915
Current exception should be:
]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.