Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PR #2976 bug due to missing adding function_name and algorithm in querying models #3104

Merged

Conversation

zane-neo
Copy link
Collaborator

Description

Fix PR #2976 bug due to missing adding function_name and algorithm in querying models

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…e and algorithm in query models

Signed-off-by: zane-neo <[email protected]>
Signed-off-by: zane-neo <[email protected]>
ylwu-amzn
ylwu-amzn previously approved these changes Oct 14, 2024
@zane-neo zane-neo merged commit 5b982c4 into opensearch-project:main Oct 15, 2024
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)
zane-neo added a commit that referenced this pull request Oct 15, 2024
… querying models (#3104) (#3113)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)

Co-authored-by: zane-neo <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104) (#3114)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)

Co-authored-by: zane-neo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants