-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PR #2976 bug due to missing adding function_name and algorithm in querying models #3104
Merged
zane-neo
merged 3 commits into
opensearch-project:main
from
zane-neo:fix-remove-remote-model-pr-bug
Oct 15, 2024
Merged
Fix PR #2976 bug due to missing adding function_name and algorithm in querying models #3104
zane-neo
merged 3 commits into
opensearch-project:main
from
zane-neo:fix-remove-remote-model-pr-bug
Oct 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e and algorithm in query models Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
October 14, 2024 10:56
zane-neo
had a problem deploying
to
ml-commons-cicd-env
October 14, 2024 10:57
— with
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
October 14, 2024 10:57
— with
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
had a problem deploying
to
ml-commons-cicd-env
October 14, 2024 11:59
— with
GitHub Actions
Failure
zane-neo
temporarily deployed
to
ml-commons-cicd-env
October 14, 2024 11:59
— with
GitHub Actions
Inactive
ylwu-amzn
previously approved these changes
Oct 14, 2024
zane-neo
temporarily deployed
to
ml-commons-cicd-env
October 14, 2024 15:41
— with
GitHub Actions
Inactive
zane-neo
had a problem deploying
to
ml-commons-cicd-env
October 14, 2024 16:39
— with
GitHub Actions
Failure
dhrubo-os
reviewed
Oct 15, 2024
plugin/src/test/java/org/opensearch/ml/autoredeploy/MLModelAutoReDeployerIT.java
Outdated
Show resolved
Hide resolved
dhrubo-os
reviewed
Oct 15, 2024
plugin/src/main/java/org/opensearch/ml/autoredeploy/MLModelAutoReDeployer.java
Show resolved
Hide resolved
Signed-off-by: zane-neo <[email protected]>
zane-neo
had a problem deploying
to
ml-commons-cicd-env
October 15, 2024 03:02
— with
GitHub Actions
Failure
zane-neo
temporarily deployed
to
ml-commons-cicd-env
October 15, 2024 03:02
— with
GitHub Actions
Inactive
dhrubo-os
reviewed
Oct 15, 2024
plugin/src/test/java/org/opensearch/ml/autoredeploy/MLModelAutoReDeployerIT.java
Show resolved
Hide resolved
dhrubo-os
approved these changes
Oct 15, 2024
b4sjoo
approved these changes
Oct 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
… querying models (#3104) * Fix PR #2976 bug due to missing adding function_name and algorithm in query models Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Move the setup mehtod body to test method body Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 5b982c4)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 15, 2024
… querying models (#3104) * Fix PR #2976 bug due to missing adding function_name and algorithm in query models Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Move the setup mehtod body to test method body Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 5b982c4)
zane-neo
added a commit
that referenced
this pull request
Oct 15, 2024
… querying models (#3104) (#3113) * Fix PR #2976 bug due to missing adding function_name and algorithm in query models Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Move the setup mehtod body to test method body Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 5b982c4) Co-authored-by: zane-neo <[email protected]>
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 15, 2024
… querying models (#3104) (#3114) * Fix PR #2976 bug due to missing adding function_name and algorithm in query models Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * Move the setup mehtod body to test method body Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit 5b982c4) Co-authored-by: zane-neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix PR #2976 bug due to missing adding function_name and algorithm in querying models
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.