Merge the existing parameters when updating connectors #2784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
dhrubo-os
approved these changes
Jul 30, 2024
b4sjoo
approved these changes
Jul 30, 2024
b4sjoo
added
v2.16.0
chishui
reviewed
Jul 30, 2024
| @@ -287,7 +287,7 @@ public void update(MLCreateConnectorInput updateContent, Function<String, String | |||
| this.protocol = updateContent.getProtocol(); | |||
| } | |||
| if (updateContent.getParameters() != null && updateContent.getParameters().size() > 0) { | |||
| this.parameters = updateContent.getParameters(); | |||
| getParameters().putAll(updateContent.getParameters()); | |||
There was a problem hiding this comment.
Add UT and integ test? Seems this logic is not tested, otherwise the change of the behavior should break existing tests
There was a problem hiding this comment.
Will do in the next PR.
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* merge the existing parameters when updating connectors Signed-off-by: Xun Zhang <[email protected]> * add more details in sagemaker model for batch inference Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit e16f38a)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* merge the existing parameters when updating connectors Signed-off-by: Xun Zhang <[email protected]> * add more details in sagemaker model for batch inference Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit e16f38a)
b4sjoo
pushed a commit
that referenced
this pull request
Jul 30, 2024
* merge the existing parameters when updating connectors Signed-off-by: Xun Zhang <[email protected]> * add more details in sagemaker model for batch inference Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit e16f38a) Co-authored-by: Xun Zhang <[email protected]>
Zhangxunmt
added a commit
that referenced
this pull request
Jul 30, 2024
* merge the existing parameters when updating connectors Signed-off-by: Xun Zhang <[email protected]> * add more details in sagemaker model for batch inference Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit e16f38a) Co-authored-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue reported in #2502. This is not a bug since the issue was an expected behavior based on the initial design of the Update Connector API. However, over time we think that, in the Update APIs, it's a better CX experience to merge the updated parameters with the existing ones.
Also, some details of the sagemaker model for batch inference is added in this PR.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.