-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Enhancement]Adding additional info for memory metadata #2750
[Enhancement]Adding additional info for memory metadata #2750
Conversation
@Zhangxunmt help review ? |
Signed-off-by: Hailong Cui <[email protected]> create conversation support additional info Signed-off-by: Hailong Cui <[email protected]> add test for search conversation Signed-off-by: Hailong Cui <[email protected]> add bwc Signed-off-by: Hailong Cui <[email protected]>
1c274b8
to
1ebc6ef
Compare
@@ -35,7 +36,7 @@ public class UpdateConversationRequest extends ActionRequest { | |||
private String conversationId; | |||
private Map<String, Object> updateContent; | |||
|
|||
private static final Set<String> allowedList = new HashSet<>(Arrays.asList(META_NAME_FIELD)); | |||
private static final Set<String> allowedList = new HashSet<>(Arrays.asList(META_NAME_FIELD, META_ADDITIONAL_INFO_FIELD)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would allow update/delete anything inside META_ADDITIONAL_INFO_FIELD. I think you need to put some restrictions to not allow updating certain fields inside it like the application/memory type, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense. We can initially make it open and then add restrictions when the need arises.
create conversation support additional info add test for search conversation add bwc Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 920685d)
…2804) create conversation support additional info add test for search conversation add bwc Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 920685d) Co-authored-by: Hailong Cui <[email protected]>
Description
Adding additional info for memory metadata
index mapping,
additional_info
is new added field withflat_object
typeAPI request/response samples
Create memory without additional info
Create new memory with additional info
Search memory
Issues Resolved
#2755
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.