change disk circuit breaker to cluster settings #2634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zane-neo <[email protected]>
zane-neo
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Signed-off-by: zane-neo <[email protected]>
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
reviewed
Jul 11, 2024
| * * Copyright OpenSearch Contributors | ||
| * * SPDX-License-Identifier: Apache-2.0 | ||
| * | ||
| */ |
There was a problem hiding this comment.
the license header seems not with right format
/*
* Copyright OpenSearch Contributors
* SPDX-License-Identifier: Apache-2.0
*/
| Integer.MAX_VALUE, | ||
| Setting.Property.NodeScope, | ||
| Setting.Property.Dynamic | ||
| ); |
There was a problem hiding this comment.
nit: another alternative could be ByteSizeValue instead of int. it has more fine-grained control.
| /** | ||
| * An abstract class for all breakers with threshold. | ||
| * @param <T> data type of threshold | ||
| */ | ||
| @Data | ||
| public abstract class ThresholdCircuitBreaker<T> implements CircuitBreaker { | ||
|
|
||
| private T threshold; |
There was a problem hiding this comment.
should we add volatile modifier for this field?
There was a problem hiding this comment.
It's better to add volatile so that each thread can read the up-to-date value of this.
Signed-off-by: zane-neo <[email protected]>
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
zane-neo
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
approved these changes
Jul 11, 2024
Zhangxunmt
approved these changes
Jul 11, 2024
b4sjoo
approved these changes
Jul 11, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 12, 2024
* change disk circuit breaker to cluster settings Signed-off-by: zane-neo <[email protected]> * Fix IT failure Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * fix failure UT Signed-off-by: zane-neo <[email protected]> * fix failure IT Signed-off-by: zane-neo <[email protected]> * Address comments Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit b6618b2)
zane-neo
added a commit
that referenced
this pull request
Jul 12, 2024
* change disk circuit breaker to cluster settings Signed-off-by: zane-neo <[email protected]> * Fix IT failure Signed-off-by: zane-neo <[email protected]> * format code Signed-off-by: zane-neo <[email protected]> * fix failure UT Signed-off-by: zane-neo <[email protected]> * fix failure IT Signed-off-by: zane-neo <[email protected]> * Address comments Signed-off-by: zane-neo <[email protected]> --------- Signed-off-by: zane-neo <[email protected]> (cherry picked from commit b6618b2) Co-authored-by: zane-neo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change disk circuit breaker to cluster settings
Issues Resolved
#2639
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.