-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix init encryption master key #2554
Conversation
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2554 +/- ##
============================================
- Coverage 81.31% 81.26% -0.06%
+ Complexity 6094 6086 -8
============================================
Files 573 573
Lines 25268 25306 +38
Branches 2666 2665 -1
============================================
+ Hits 20547 20565 +18
- Misses 3601 3616 +15
- Partials 1120 1125 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
||
try { | ||
latch.await(5, SECONDS); | ||
latch.await(1, SECONDS); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we make sure the blocking here is safe? It won't have impact on other threads like event loop? Initiating a master key doesn't seem a long running job(writing index), why we're using a blocking fashion to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a perfect fix. Just for quickly unblock query assistant. Did testing on single node and multi-node cluster, looks good. At least this part is same with before, just reduce timeout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbhavna will have a long-term fix which will remove such await
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rbhavna please create an issue to track this.
Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Yaliang Wu <[email protected]>
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a)
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a)
* fix init master key Signed-off-by: Yaliang Wu <[email protected]>
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a) Co-authored-by: Yaliang Wu <[email protected]>
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a) Co-authored-by: Yaliang Wu <[email protected]>
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-feature/multi_tenancy feature/multi_tenancy
# Navigate to the new working tree
cd .worktrees/backport-feature/multi_tenancy
# Create a new branch
git switch --create backport/backport-2554-to-feature/multi_tenancy
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 487f33a2e35e642429e9a3ea1eb0d715d542ea9f
# Push it to GitHub
git push --set-upstream origin backport/backport-2554-to-feature/multi_tenancy
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-feature/multi_tenancy Then, create a pull request where the |
* fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a) Co-authored-by: Yaliang Wu <[email protected]>
…project#2606) * fix init master key Signed-off-by: Yaliang Wu <[email protected]> (cherry picked from commit 487f33a) Co-authored-by: Yaliang Wu <[email protected]> Signed-off-by: Arjun kumar Giri <[email protected]>
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.