Added missing result filter to inference #2367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: br3no <[email protected]>
br3no
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
samuel-oci and
xinyual
as code owners
br3no
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
br3no
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Error
br3no
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
@dhrubo-os @ylwu-amzn, this is related to the PR of earlier this week (#2318). I'm sorry about this back-and-forth. The fact that the feature is spread across ml-commons and neural-search makes things a bit more involved. I'm pretty confident though, that this is the last piece missing. I was able to test all changes in combination end-to-end today (this is how the bug surfaced). |
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
br3no
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Apr 27, 2024
mingshl
approved these changes
Apr 27, 2024
dhrubo-os
approved these changes
Apr 28, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 28, 2024
Signed-off-by: br3no <[email protected]> (cherry picked from commit caf1d65)
ylwu-amzn
pushed a commit
that referenced
this pull request
Apr 28, 2024
Signed-off-by: br3no <[email protected]> (cherry picked from commit caf1d65) Co-authored-by: Breno Faria <[email protected]>
mingshl
added
v2.14.0
enhancement
|
@br3no , I see you have contributed several PRs to ml-commons repo. Really appreciate your contribution. Considering that, do you mind to become a maintainer of ml-commons repo? |
|
@ylwu-amzn I'm flattered. 😉 Let me think about this and come back to you. |
|
@ylwu-amzn I'm in. Let me know what the next steps are. |
dhrubo-os
pushed a commit
to dhrubo-os/ml-commons
that referenced
this pull request
May 17, 2024
…pensearch-project#2370) Signed-off-by: br3no <[email protected]> (cherry picked from commit caf1d65) Co-authored-by: Breno Faria <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The missing result filter is added to the code path where it was forgotten in an earlier PR.
Issues Resolved
#2366
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.