Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] asymmetric model inference ignores ModelResultFilter #2366

Closed
br3no opened this issue Apr 26, 2024 · 1 comment
Closed

[BUG] asymmetric model inference ignores ModelResultFilter #2366

br3no opened this issue Apr 26, 2024 · 1 comment
Labels
bug Something isn't working untriaged

Comments

@br3no
Copy link
Contributor

br3no commented Apr 26, 2024

What is the bug?
There is a small bug in the TextEmbeddingModel class in relation with the new asymmetric model support. In the method addPrefixesToData, that is only called when an asymmetric model is used, I forgot to add the existing result filter to the new instance of the TextDocsInputDataSet that is created with the corresponding prefixes.

I noticed the issue while working on opensearch-project/neural-search#710.

How can one reproduce the bug?
Steps to reproduce the behavior:

  1. run inference on an asymmetric model using a result filter
  2. see that the result filter will not be applied

What is the expected behavior?
The result filter should be applied.

What is your host/environment?

  • OS: all

Do you have any screenshots?
N.a.

Do you have any additional context?
I have a fix and will open a PR immediately.

@br3no br3no added bug Something isn't working untriaged labels Apr 26, 2024
@br3no
Copy link
Contributor Author

br3no commented Apr 29, 2024

Closing issue, as fix has been merged.

@br3no br3no closed this as completed Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working untriaged
Projects
None yet
Development

No branches or pull requests

1 participant