You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the bug?
There is a small bug in the TextEmbeddingModel class in relation with the new asymmetric model support. In the method addPrefixesToData, that is only called when an asymmetric model is used, I forgot to add the existing result filter to the new instance of the TextDocsInputDataSet that is created with the corresponding prefixes.
What is the bug?
There is a small bug in the
TextEmbeddingModel
class in relation with the new asymmetric model support. In the methodaddPrefixesToData
, that is only called when an asymmetric model is used, I forgot to add the existing result filter to the new instance of theTextDocsInputDataSet
that is created with the corresponding prefixes.I noticed the issue while working on opensearch-project/neural-search#710.
How can one reproduce the bug?
Steps to reproduce the behavior:
What is the expected behavior?
The result filter should be applied.
What is your host/environment?
Do you have any screenshots?
N.a.
Do you have any additional context?
I have a fix and will open a PR immediately.
The text was updated successfully, but these errors were encountered: