Bump up C++ version in JNI from c++11 to c++17. #2259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0ctopus13prime
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
ryanbogan,
luyuncheng and
shatejas
as code owners
0ctopus13prime
force-pushed
the
jni-cpp17
branch
from
932aeec
to
cf34761
Compare
0ctopus13prime
commented
Nov 7, 2024
| @@ -197,7 +197,7 @@ public void testGetTrainingSize() throws ExecutionException { | |||
|
|
|||
| nativeMemoryCacheManager.get(trainingDataEntryContext, true); | |||
|
|
|||
| assertEquals((float) allocationEntryWeight, nativeMemoryCacheManager.getTrainingSizeInKilobytes(), 0.001); | |||
| assertEquals(allocationEntryWeight, nativeMemoryCacheManager.getTrainingSizeInKilobytes(), 1e-3); | |||
There was a problem hiding this comment.
I fixed this flaky testing where it fails the testing by one.
(float) allocationEntryWeight == 2.1430328E7
nativeMemoryCacheManager.getTrainingSizeInKilobytes() == 21430329
0ctopus13prime
force-pushed
the
jni-cpp17
branch
from
cf34761
to
68d94a0
Compare
|
Failed rolling update will be fixed in here - #2260 |
|
Failure in |
Signed-off-by: Dooyong Kim <[email protected]>
0ctopus13prime
force-pushed
the
jni-cpp17
branch
from
68d94a0
to
4e5de3d
Compare
|
Rolling upgrade 2.11 to 3.00 is failing due to the network error: |
jmazanec15
approved these changes
Nov 8, 2024
navneet1v
approved these changes
Nov 8, 2024
navneet1v
added
Infrastructure
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]> (cherry picked from commit a07bad1)
navneet1v
pushed a commit
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Dooyong Kim <[email protected]> Co-authored-by: Dooyong Kim <[email protected]> (cherry picked from commit a07bad1) Co-authored-by: Doo Yong Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR bumped up C++ version in JNI from c++11 to c++17.
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
#2251
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.