-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compilation errors after refactoring in core foundation classes #1038
Fixed compilation errors after refactoring in core foundation classes #1038
Conversation
Signed-off-by: Martin Gaievski <[email protected]>
Cool, just now I made the changes to fix these compilation errors and about to raise a PR |
Codecov Report
@@ Coverage Diff @@
## main #1038 +/- ##
============================================
- Coverage 85.33% 85.03% -0.30%
+ Complexity 1149 1144 -5
============================================
Files 154 154
Lines 4692 4692
Branches 425 425
============================================
- Hits 4004 3990 -14
- Misses 497 509 +12
- Partials 191 193 +2
|
BWC will fail as there are problems with 2.10.0 build |
74b87e8
into
opensearch-project:main
…#1038) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 74b87e8)
…opensearch-project#1038) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 74b87e8)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1038-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74b87e87e9ddb9593712a7443997bda04144b38b
# Push it to GitHub
git push --set-upstream origin backport/backport-1038-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…opensearch-project#1038) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 74b87e8)
…opensearch-project#1038) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 74b87e8) Signed-off-by: Martin Gaievski <[email protected]>
…ndation classes (#1038) (#1048) * Fixed compilation errors after refactoring in core foundation classes (#1038) Signed-off-by: Martin Gaievski <[email protected]> --------- Signed-off-by: Martin Gaievski <[email protected]>
Description
Fixed compilation errors after refactoring in core foundation classes (opensearch-project/OpenSearch#9082)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.