-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed compilation errors after recent changes in core #1031
Merged
martin-gaievski
merged 1 commit into
opensearch-project:main
from
martin-gaievski:fix-errors-after-refarctorings-in-core
Aug 8, 2023
Merged
Fixed compilation errors after recent changes in core #1031
martin-gaievski
merged 1 commit into
opensearch-project:main
from
martin-gaievski:fix-errors-after-refarctorings-in-core
Aug 8, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda and
junqiu-lei
as code owners
August 8, 2023 01:20
heemin32
previously approved these changes
Aug 8, 2023
martin-gaievski
force-pushed
the
fix-errors-after-refarctorings-in-core
branch
from
August 8, 2023 04:46
85dfaf5
to
80bf7a9
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
fix-errors-after-refarctorings-in-core
branch
from
August 8, 2023 16:06
80bf7a9
to
675c393
Compare
Codecov Report
@@ Coverage Diff @@
## main #1031 +/- ##
============================================
- Coverage 85.33% 85.10% -0.24%
+ Complexity 1149 1144 -5
============================================
Files 154 154
Lines 4692 4692
Branches 425 425
============================================
- Hits 4004 3993 -11
- Misses 497 506 +9
- Partials 191 193 +2
|
BWC tests will fail now, there is an issue with core 2.10.0 build |
martin-gaievski
added
the
Maintenance
Add support for new versions of OpenSearch/Dashboards from upstream
label
Aug 8, 2023
navneet1v
approved these changes
Aug 8, 2023
5 tasks
naveentatikonda
approved these changes
Aug 8, 2023
martin-gaievski
merged commit Aug 8, 2023
0a7fc4e
into
opensearch-project:main
17 of 43 checks passed
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1031-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0a7fc4e3d382c17bcd3537a6d625eec07f23085d
# Push it to GitHub
git push --set-upstream origin backport/backport-1031-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
smortex
pushed a commit
to smortex/k-NN
that referenced
this pull request
Aug 9, 2023
…ject#1031) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 0a7fc4e)
martin-gaievski
added a commit
that referenced
this pull request
Aug 16, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 0a7fc4e) Co-authored-by: Martin Gaievski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
Maintenance
Add support for new versions of OpenSearch/Dashboards from upstream
skip-changelog
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed compilation errors after changes in core Strings classes (opensearch-project/OpenSearch#9103)
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.